[SYCL][buildbot] add ARM target option to buildbot/configure.py #2322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff R. Hammond <[email protected]>
vladimirlaz
approved these changes
Aug 15, 2020
bader
reviewed
Aug 17, 2020
| @@ -38,6 +38,10 @@ def do_configure(args): | |||
| libclc_targets_to_build = 'nvptx64--;nvptx64--nvidiacl' | |||
| sycl_build_pi_cuda = 'ON' | |||
|
|
|||
| # replace not append, so ARM ^ X86 | |||
There was a problem hiding this comment.
Could you clarify why "replace" instead of "append"?
|
The motivation is that we aren’t testing cross-compilation, and the build takes a long time on many ARM platforms without including X86.
Once I get PowerPC working, I’ll generalize this option.
|
bader
approved these changes
Aug 17, 2020
Thanks. |
|
Just FYI: you can build LLVM for ARM targets only w/o adding a new option by adding following flag for configure.py script.
configure.py --cmake-opt=-DLLVM_TARGETS_TO_BUILD="ARM;AArch64"
I tried that. CMake was giving me a bad time.
|
jsji
pushed a commit
that referenced
this pull request
Feb 2, 2024
…check (#2322) Guard placing a DIExpression in SPIR-V's DebugGlobalVariable's Variable field with a nonsemantic check. Signed-off-by: Lu, John <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@e329f28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested on Raspberry Pi 4 and Cavium ThunderX2 running Ubuntu AArch64. The build also depends on my fixes for #2304, but those are not ready. Nonetheless, this fix is independent of that one and can be merged without side effects.
There is a clearly a more general solution here, but it seems imprudent to add architectures to the buildbot testing until they have actually been tested somewhere. Once I have a chance to test on PowerPC, I'll see about adding that as an explicit target, or provide a more general solution (e.g.
--arch=..).Resolves #2313.
Signed-off-by: Jeff R. Hammond [email protected]