Fixes enabling hierarchical parallelism API. #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
requested changes
Jun 21, 2019
Device code in the SYCL runtime library may want to reuse SPIRV-based initialization of current group and item id, size and offset - factor them out into a separate header. Signed-off-by: Konstantin S Bobrovsky <[email protected]>
vladimirlaz
reviewed
Jun 24, 2019
agozillon
previously approved these changes
Jun 24, 2019
Remove "template overloads" of single_task and parallel_for invocation APIs leading to template instantiation ambiguity in some cases and causing compilation errors. The APIs with KernelName and KernelType template parameters are changed to infer correct KernelName in both lambda and functor flavors of API invocation. Signed-off-by: Konstantin S Bobrovsky <[email protected]>
The feedback was useful and is always welcome. Thanks! |
bader
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#221 will be split into 2 parts - enabling fixes and the hierarchical parallelism part itself. This is the enabling part. All (hopefully) the review comments from the original PR related to these fixes were addressed.