-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Adjust devicelib install location #2405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Adjust devicelib install location #2405
Conversation
This patch will do following: 1. Rename all .o libraries to .obj on Windows 2. Install all .obj libraries in lib/ on Windows 3. Uniform the previous libsycl-glibc and libsycl-msvc to libsycl-crt.o/obj Signed-off-by: gejin <[email protected]>
@jinge90 , please provide brief description of the problem this patch solves. |
Currently, device libraries included .o and .spv libraries. The ".o" libraries are for offline link with users' device code and .spv libraries are to be loaded and linked during runtime by sycl RT. bin/ is for dynamic libraries on Windows and lib/ is for static libraries. The spv libraries are some kind of "dynamic" libraries, putting them into bin/ seems to align with Windows' style. |
Signed-off-by: gejin <[email protected]>
Please fix the LIT tests, otherwise LGTM |
Signed-off-by: gejin <[email protected]>
…l structure Signed-off-by: gejin <[email protected]>
Hi, @vzakhari |
Signed-off-by: gejin <[email protected]>
Hi, @asavonic |
Add sanitizer ignorelist for cfi
This patch will do following:
Signed-off-by: gejin [email protected]