Skip to content

[SYCL][Deps]Uplift Windows GPU RT from 8673 to 8778 #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

yanfeng3721
Copy link
Contributor

This PR is used for Windows GPU RT uplift test.

@bader
Copy link
Contributor

bader commented Sep 22, 2020

/summary:run

@bader
Copy link
Contributor

bader commented Sep 22, 2020

@yanfeng3721, please, update LIT tests to fix the regressions.

@yanfeng3721
Copy link
Contributor Author

/summary:run

@bader
Copy link
Contributor

bader commented Sep 23, 2020

@yanfeng3721, please, update two more tests.

@bader
Copy link
Contributor

bader commented Sep 23, 2020

BTW, re-running Jenkins summary job is not necessary. Your new patch updates only LIT tests, so I expect the same results as for the first version of the patch.
To simplify tracking of pre-commit testing results and code review comments, it's recommended to avoid force-pushing.

@yanfeng3721
Copy link
Contributor Author

BTW, re-running Jenkins summary job is not necessary. Your new patch updates only LIT tests, so I expect the same results as for the first version of the patch.
To simplify tracking of pre-commit testing results and code review comments, it's recommended to avoid force-pushing.

Ok,

@yanfeng3721
Copy link
Contributor Author

Close by mistake, reopen it.

@yanfeng3721 yanfeng3721 reopened this Sep 23, 2020
@@ -7,8 +7,8 @@ ocl_cpu_rt_ver_win=2020.11.8.0.27
# https://github.com/intel/compute-runtime/releases/tag/20.35.17767
ocl_gpu_rt_ver=20.35.17767
# Same GPU driver supports Level Zero and OpenCL:
# https://downloadmirror.intel.com/29817/a08/igfx_win10_100.8673.zip
ocl_gpu_rt_ver_win=27.20.100.8673
# https://downloadmirror.intel.com/29817/a08/igfx_win10_100.8778.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got https://www.intel.com/content/www/us/en/404.html when try to download RT
Please fix the link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vladimir, it is expected. The Windows GPU RT 8778 is not published yet. The ETA is WW40.2

@bader
Copy link
Contributor

bader commented Sep 23, 2020

@yanfeng3721, there are failures on Windows.
This looks like a CI bug - sycl-win-x64-pr job uses old driver instead of new one.
http://ci.llvm.intel.com:8010/#/builders/18/builds/4879/steps/9/logs/stdio

Platform [#3] :
Profile : FULL_PROFILE
Version : OpenCL 2.1
Name : Intel(R) OpenCL HD Graphics
Vendor : Intel(R) Corporation
Devices : 1
Device [#1] :
Type : GPU
Profile : FULL_PROFILE
Version : OpenCL 2.1 NEO
Name : Intel(R) UHD Graphics 630
Vendor : Intel(R) Corporation
C version : OpenCL C 2.0
Driver version : 27.20.100.8673

Please, report this issue to CI team.

@yinyangsx
Copy link

@yanfeng3721, there are failures on Windows.
This looks like a CI bug - sycl-win-x64-pr job uses old driver instead of new one.
http://ci.llvm.intel.com:8010/#/builders/18/builds/4879/steps/9/logs/stdio

Platform [#3] :
Profile : FULL_PROFILE
Version : OpenCL 2.1
Name : Intel(R) OpenCL HD Graphics
Vendor : Intel(R) Corporation
Devices : 1
Device [#1] :
Type : GPU
Profile : FULL_PROFILE
Version : OpenCL 2.1 NEO
Name : Intel(R) UHD Graphics 630
Vendor : Intel(R) Corporation
C version : OpenCL C 2.0
Driver version : 27.20.100.8673

Please, report this issue to CI team.

Hi @bader, I have rebuild this job on specific worker which has 8778 driver, http://ci.llvm.intel.com:8010/#/builders/18/builds/4881
Link will update when it finish.

@bader
Copy link
Contributor

bader commented Sep 23, 2020

@yanfeng3721, there are failures on Windows.
This looks like a CI bug - sycl-win-x64-pr job uses old driver instead of new one.
http://ci.llvm.intel.com:8010/#/builders/18/builds/4879/steps/9/logs/stdio
Platform [#3] :
Profile : FULL_PROFILE
Version : OpenCL 2.1
Name : Intel(R) OpenCL HD Graphics
Vendor : Intel(R) Corporation
Devices : 1
Device [#1] :
Type : GPU
Profile : FULL_PROFILE
Version : OpenCL 2.1 NEO
Name : Intel(R) UHD Graphics 630
Vendor : Intel(R) Corporation
C version : OpenCL C 2.0
Driver version : 27.20.100.8673
Please, report this issue to CI team.

Hi @bader, I have rebuild this job on specific worker which has 8778 driver, http://ci.llvm.intel.com:8010/#/builders/18/builds/4881
Link will update when it finish.

@yinyangsx, I expected that buildbot/dependency.conf configures the driver on buildbot worker. Am I wrong?

@bader
Copy link
Contributor

bader commented Sep 23, 2020

@yanfeng3721, http://ci.llvm.intel.com:8010/#/builders/2/builds/5308/steps/15/logs/FAIL__SYCL__asm_no_operands_cpp failure seems to be unrelated to your change. Please, file a bug report to investigate it separately.

@yinyangsx
Copy link

@yanfeng3721, there are failures on Windows.
This looks like a CI bug - sycl-win-x64-pr job uses old driver instead of new one.
http://ci.llvm.intel.com:8010/#/builders/18/builds/4879/steps/9/logs/stdio
Platform [#3] :
Profile : FULL_PROFILE
Version : OpenCL 2.1
Name : Intel(R) OpenCL HD Graphics
Vendor : Intel(R) Corporation
Devices : 1
Device [#1] :
Type : GPU
Profile : FULL_PROFILE
Version : OpenCL 2.1 NEO
Name : Intel(R) UHD Graphics 630
Vendor : Intel(R) Corporation
C version : OpenCL C 2.0
Driver version : 27.20.100.8673
Please, report this issue to CI team.

Hi @bader, I have rebuild this job on specific worker which has 8778 driver, http://ci.llvm.intel.com:8010/#/builders/18/builds/4881
Link will update when it finish.

@yinyangsx, I expected that buildbot/dependency.conf configures the driver on buildbot worker. Am I wrong?

Windows GPU RT doesn't like others which are in share folder, it has to be installed into machine. So we can't set windows GPU version by modify dependency.conf. The GPU version in dependency.conf just for showing.

@bader bader merged commit a3d5fa4 into intel:sycl Sep 23, 2020
@bader
Copy link
Contributor

bader commented Sep 23, 2020

Windows GPU RT doesn't like others which are in share folder, it has to be installed into machine. So we can't set windows GPU version by modify dependency.conf. The GPU version in dependency.conf just for showing.

Can BuildBot select properly configured worker based on the information from dependency.conf file?

@yinyangsx
Copy link

Windows GPU RT doesn't like others which are in share folder, it has to be installed into machine. So we can't set windows GPU version by modify dependency.conf. The GPU version in dependency.conf just for showing.

Can BuildBot select properly configured worker based on the information from dependency.conf file?

No, we have to select manually

@bader
Copy link
Contributor

bader commented Sep 23, 2020

Windows GPU RT doesn't like others which are in share folder, it has to be installed into machine. So we can't set windows GPU version by modify dependency.conf. The GPU version in dependency.conf just for showing.

Can BuildBot select properly configured worker based on the information from dependency.conf file?

No, we have to select manually

How difficult it would be to automate the selection of correctly configured worker?
We can't trust CI results w/o checking manually consistency of the environment captured in the logs with the dependency.conf.

bader pushed a commit that referenced this pull request Sep 23, 2020
@yinyangsx
Copy link

yinyangsx commented Sep 23, 2020

We can't trust CI results w/o checking manually consistency of the environment captured in the logs with the dependency.conf.

For Windows GPU version, I think we can add a feature to do version checking in 'check_env' stage.

@bader
Copy link
Contributor

bader commented Sep 23, 2020

We can't trust CI results w/o checking manually consistency of the environment captured in the logs with the dependency.conf.

For Windows GPU version, I think we can add a feature to do version checking in 'check_env' stage.

That is not as good as automatic selection of correctly configured worker, but it sounds like an improvement to me.
👍

yanfeng3721 added a commit that referenced this pull request Sep 24, 2020
iclsrc pushed a commit that referenced this pull request Apr 11, 2024
…cess to a buildin variable (#2487)

This PR is to fix the issue when SPIRV Translator expects now to see exactly GetElementPtrInst in an access chain for a builtin variable and crashes in lib/SPIRV/SPIRVUtil.cpp in replaceUsesOfBuiltinVar() with llvm_unreachable() call. See #2486 for the detailed description. Attached is a test case that demonstrates the problem and leads to a crash in current version(s) of SPIRV Translator.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@a7051670770f471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants