-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][Deps]Uplift Windows GPU RT from 8673 to 8778 #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/summary:run |
@yanfeng3721, please, update LIT tests to fix the regressions. |
231b5da
to
afd6628
Compare
/summary:run |
@yanfeng3721, please, update two more tests. |
BTW, re-running Jenkins summary job is not necessary. Your new patch updates only LIT tests, so I expect the same results as for the first version of the patch. |
afd6628
to
b2faed1
Compare
Ok, |
Close by mistake, reopen it. |
@@ -7,8 +7,8 @@ ocl_cpu_rt_ver_win=2020.11.8.0.27 | |||
# https://github.com/intel/compute-runtime/releases/tag/20.35.17767 | |||
ocl_gpu_rt_ver=20.35.17767 | |||
# Same GPU driver supports Level Zero and OpenCL: | |||
# https://downloadmirror.intel.com/29817/a08/igfx_win10_100.8673.zip | |||
ocl_gpu_rt_ver_win=27.20.100.8673 | |||
# https://downloadmirror.intel.com/29817/a08/igfx_win10_100.8778.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got https://www.intel.com/content/www/us/en/404.html when try to download RT
Please fix the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Vladimir, it is expected. The Windows GPU RT 8778 is not published yet. The ETA is WW40.2
@yanfeng3721, there are failures on Windows. Platform [#3] : Please, report this issue to CI team. |
Hi @bader, I have rebuild this job on specific worker which has 8778 driver, http://ci.llvm.intel.com:8010/#/builders/18/builds/4881 |
@yinyangsx, I expected that buildbot/dependency.conf configures the driver on buildbot worker. Am I wrong? |
@yanfeng3721, http://ci.llvm.intel.com:8010/#/builders/2/builds/5308/steps/15/logs/FAIL__SYCL__asm_no_operands_cpp failure seems to be unrelated to your change. Please, file a bug report to investigate it separately. |
Windows GPU RT doesn't like others which are in share folder, it has to be installed into machine. So we can't set windows GPU version by modify dependency.conf. The GPU version in dependency.conf just for showing. |
Can BuildBot select properly configured worker based on the information from dependency.conf file? |
No, we have to select manually |
How difficult it would be to automate the selection of correctly configured worker? |
This reverts commit a3d5fa4.
For Windows GPU version, I think we can add a feature to do version checking in 'check_env' stage. |
That is not as good as automatic selection of correctly configured worker, but it sounds like an improvement to me. |
…cess to a buildin variable (#2487) This PR is to fix the issue when SPIRV Translator expects now to see exactly GetElementPtrInst in an access chain for a builtin variable and crashes in lib/SPIRV/SPIRVUtil.cpp in replaceUsesOfBuiltinVar() with llvm_unreachable() call. See #2486 for the detailed description. Attached is a test case that demonstrates the problem and leads to a crash in current version(s) of SPIRV Translator. Original commit: KhronosGroup/SPIRV-LLVM-Translator@a7051670770f471
This PR is used for Windows GPU RT uplift test.