[Driver][SYCL] Adjust /MD settings for SYCL device compilations #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
previously approved these changes
Sep 19, 2020
|
I was a little over zealous in determining device compilations - cleaned that up. Also make sure that the error message of usage is only emitted once. |
v-klochkov
previously approved these changes
Sep 20, 2020
AGindinson
reviewed
Sep 21, 2020
AGindinson
previously approved these changes
Sep 21, 2020
v-klochkov
previously approved these changes
Sep 21, 2020
|
Oops, I did not notice sycl-MD-default.cpp test failed. |
When setting /MD (by default) we do not want to pass the _MT and _DLL predefines to the device compilations, only the host for clang-cl
mdtoguchi
dismissed stale reviews from v-klochkov and AGindinson
via
11aa94f
mdtoguchi
force-pushed
the
private/mdtoguchi/restrict-DLL-MT-device
branch
from
1450afd to
11aa94f
Compare
AGindinson
approved these changes
Sep 21, 2020
v-klochkov
added a commit
to v-klochkov/llvm
that referenced
this pull request
Mar 26, 2021
…t -fsycl With -fsycl switch the dynamic runtime is used. The patches (intel#2478, intel#2480, intel#2497 implemented that with -fsycl. This patch adds check that dynamic runtime is used when -fsycl is not used. That is done by a static_assert in sycl/stl.hpp. Also, lots of LIT tests had to be changed to comply with the new requirement (apps must use dynamic C++ RT with use SYCL). Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
added a commit
that referenced
this pull request
Mar 31, 2021
With -fsycl switch the dynamic runtime is used. The patches (#2478, #2480, #2497 implemented that with -fsycl. Applications using sycl headers and linked with sycl[d].dll must be linked with dynamic C++ runtime on Windows even if compiled without -fsycl. This patch adds a compile time warning emitted when wrong C++ runtime is used. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
jsji
pushed a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting /MD (by default) we do not want to pass the _MT and _DLL
predefines to the device compilations, only the host for clang-cl