Skip to content

[SYCL] Fix mem-leak/potential SegFault in LIT test, add 2 required bu… #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 17, 2021
Merged

[SYCL] Fix mem-leak/potential SegFault in LIT test, add 2 required bu… #2591

merged 7 commits into from
Feb 17, 2021

Conversation

v-klochkov
Copy link
Contributor

…ffer ctors

Signed-off-by: Vyacheslav N Klochkov [email protected]

@v-klochkov v-klochkov requested review from bader and jbrodman October 3, 2020 07:51
@v-klochkov v-klochkov mentioned this pull request Oct 8, 2020
Merged
@bader
Copy link
Contributor

bader commented Oct 19, 2020

@v-klochkov, are you still going to commit this patch?

@v-klochkov
Copy link
Contributor Author

@v-klochkov, are you still going to commit this patch?

This PR adds 2 unspecified constructors to buffer class. It is better to wait for those constructors to be added to SYCL-2020 SPEC before proceeding with the checkin.
I can cancel this PR if it inconvenient to have this PR here/now.

@bader
Copy link
Contributor

bader commented Oct 20, 2020

This PR adds 2 unspecified constructors to buffer class.
It is better to wait for those constructors to be added to SYCL-2020 SPEC before proceeding with the checkin.

@intel/dpcpp-specification-reviewers, @gmlueck, are these constructors expected to be added to SYCL specification?

@v-klochkov v-klochkov requested a review from mkinsner October 21, 2020 03:32
@v-klochkov
Copy link
Contributor Author

This PR adds 2 unspecified constructors to buffer class.
It is better to wait for those constructors to be added to SYCL-2020 SPEC before proceeding with the checkin.

@intel/dpcpp-specification-reviewers, @gmlueck, are these constructors expected to be added to SYCL specification?

Added @mkinsner to reviewers, the issue was discussed with Mike previously.

bader
bader requested changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a regression test.

@v-klochkov v-klochkov force-pushed the public_vklochkov_mem_leaks3 branch from e06ea43 to da51ec6 Compare February 9, 2021 18:27
@v-klochkov
Copy link
Contributor Author

Please, add a regression test.

Added in da51ec6

@v-klochkov
clang-format
98ee782 
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
@v-klochkov v-klochkov marked this pull request as ready for review February 11, 2021 16:39
@v-klochkov v-klochkov requested a review from a team as a code owner February 11, 2021 16:39
@v-klochkov v-klochkov requested review from rbegam and bader February 11, 2021 16:39
@v-klochkov
Copy link
Contributor Author

2 buffer constructors implemented in this patch are part of SYCL-2020: https://www.khronos.org/registry/SYCL/specs/sycl-2020/html/sycl-2020.html#_buffer_interface

@v-klochkov
Copy link
Contributor Author

@rbegam, @intel/llvm-reviewers-runtime - please review/approve the fix.

@v-klochkov v-klochkov requested a review from againull February 17, 2021 17:15
@againull againull merged commit bdfad9e into intel:sycl Feb 17, 2021
@v-klochkov v-klochkov deleted the public_vklochkov_mem_leaks3 branch February 17, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@againull againull againull approved these changes

@jbrodman jbrodman Awaiting requested review from jbrodman

@mkinsner mkinsner Awaiting requested review from mkinsner

@rbegam rbegam Awaiting requested review from rbegam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-klochkov @bader @againull