Skip to content

[SYCL][NFC] Code clean up (phase 5) revealed by self build. #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2020
Merged

[SYCL][NFC] Code clean up (phase 5) revealed by self build. #2907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions clang/include/clang/Sema/Sema.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,9 +410,6 @@ class SYCLIntegrationHeader {
/// integration header emission time.
llvm::SmallVector<SpecConstID, 4> SpecConsts;

/// Used for emitting diagnostics.
DiagnosticsEngine &Diag;

/// Whether header is generated with unnamed lambda support
bool UnnamedLambdaSupport;

Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Driver/Driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5117,7 +5117,7 @@ void Driver::BuildActions(Compilation &C, DerivedArgList &Args,
OffloadBuilder.addDeviceDependencesToHostAction(
Current, InputArg, phases::Link, PL.back(), PL);
};
for (const StringRef &LA : LinkArgs) {
for (StringRef LA : LinkArgs) {
// At this point, we will process the archives for FPGA AOCO and individual
// archive unbundling for Windows.
if (!isStaticArchiveFile(LA))
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Sema/SemaSYCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3988,7 +3988,7 @@ void SYCLIntegrationHeader::setCallsThisItem(bool B) {
SYCLIntegrationHeader::SYCLIntegrationHeader(DiagnosticsEngine &_Diag,
bool _UnnamedLambdaSupport,
Sema &_S)
: Diag(_Diag), UnnamedLambdaSupport(_UnnamedLambdaSupport), S(_S) {}
: UnnamedLambdaSupport(_UnnamedLambdaSupport), S(_S) {}

// -----------------------------------------------------------------------------
// Utility class methods
Expand Down