[SYCL] Allow user control over range rounding, and disable for older SYCL spec. #3082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SYCL spec. Signed-off-by: rdeodhar <[email protected]>
|
This patch is unrelated to #3020. |
romanovvlad
requested changes
Jan 25, 2021
sycl/test/basic_tests/parallel_for_disable_range_roundup_syclstd.cpp
Outdated
Show resolved
Hide resolved
sycl/test/basic_tests/parallel_for_disable_range_roundup_syclstd.cpp
Outdated
Show resolved
Hide resolved
sycl/test/basic_tests/parallel_for_disable_range_roundup_syclstd.cpp
Outdated
Show resolved
Hide resolved
romanovvlad
approved these changes
Jan 26, 2021
|
@rdeodhar, please post link to new/updated tests in llvm-test-suite here. I missed this on merge. |
|
Yes, I am working on adding a test to llvm-test-suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets users choose at compile-time whether to do range-rounding.
Rounding is always disabled when using older SYCL specs because the implementation creates const lambdas, which are incompatible with the mutable lambdas allowed in the old spec.
Signed-off-by: rdeodhar [email protected]