[SYCL][NFC] Update Attribute Document #3102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed the following restrictions on intel#1878 // Allow the following kernel attributes only on lambda functions and // function objects that are called directly from a kernel (i.e. the one // passed to the parallel_for function). For all other cases, // emit a warning and ignore. 1. SYCLIntelKernelArgsRestrictAttr 2. SYCLIntelNumSimdWorkItemsAttr 3. SYCLIntelMaxWorkGroupSizeAttr 4. SYCLIntelMaxGlobalWorkDimAttr This patch updates the attribute document to reflect the changes since we do not ignore the kernel attributes anymore if it is applied to a function called from a device kernel and the attribute gets propagated to a kernel. Signed-off-by: Soumi Manna <[email protected]>
smanna12
requested review from
elizabethandrews and
premanandrao
as code owners
| @@ -2199,7 +2199,7 @@ attribute was applied. This effect is equivalent to annotating restrict on | |||
| **all** kernel pointer arguments in an OpenCL or SPIR-V kernel. | |||
|
|
|||
| If ``intel::kernel_args_restrict`` is applied to a function called from a device | |||
| kernel, the attribute is ignored and it is not propagated to a kernel. | |||
| kernel, the attribute is not ignored and it is propagated to a kernel. | |||
There was a problem hiding this comment.
I would change it to '... is propagated to the kernel', since it is the same kernel we are talking about. (i.e. 'the' instead of 'a' in that sentence.)
Here and the other three places below as well.
There was a problem hiding this comment.
Thanks @premanandrao. Fixed now.
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
premanandrao
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the following restrictions on #1878
// Allow the following kernel attributes only on lambda functions and
// function objects that are called directly from a kernel (i.e. the one
// passed to the parallel_for function). For all other cases,
// emit a warning and ignore.
This patch updates the attribute document to reflect the changes since
we do not ignore the above kernel attributes anymore if it is applied to a function
called from a device kernel and the attribute gets propagated to a kernel.
Signed-off-by: Soumi Manna [email protected]