-
Notifications
You must be signed in to change notification settings - Fork 768
[SYCL] Enable program cache if build options are set #3277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable in-memory program cache for programs when build options are provided. Three sources of build options are supported: - SYCL API (e.g. build options passed to build_with_kernel_type() method); - build options specifed in the program image; - SYCL_PROGRAM_COMPILE_OPTIONS, SYCL_PROGRAM_LINK_OPTIONS environment variable (overrides options from first two points. - optimize cache map keys: - add build options to program cache map keys; - remove device ID from kernel cache map keys.
/summary:run |
dm-vodopyanov
previously approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kbobrovs, could you please have a look/approve? |
kbobrovs
reviewed
Mar 4, 2021
@kbobrovs, @dm-vodopyanov could you please have a look? |
dm-vodopyanov
approved these changes
Mar 5, 2021
kbobrovs
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provided. Three sources of build options are supported:
method);
variable (overrides options from first two points.