Skip to content

[SYCL] Enable program cache if build options are set #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2021

Conversation

vladimirlaz
Copy link
Contributor

  • Enable in-memory program cache for programs when build options are
    provided. Three sources of build options are supported:
    • SYCL API (e.g. build options passed to build_with_kernel_type()
      method);
    • build options specifed in the program image;
    • SYCL_PROGRAM_COMPILE_OPTIONS, SYCL_PROGRAM_LINK_OPTIONS environment
      variable (overrides options from first two points.
  • optimize cache map keys:
    • add build options to program cache map keys;
    • remove device ID from kernel cache map keys.

 - Enable in-memory program cache for programs when build options are
provided. Three sources of build options are supported:
   - SYCL API (e.g. build options passed to build_with_kernel_type()
method);
   - build options specifed in the program image;
   - SYCL_PROGRAM_COMPILE_OPTIONS, SYCL_PROGRAM_LINK_OPTIONS environment
variable (overrides options from first two points.
 - optimize cache map keys:
   - add build options to program cache map keys;
   - remove device ID from kernel cache map keys.
@vladimirlaz vladimirlaz requested review from kbobrovs and a team as code owners March 1, 2021 19:29
@vladimirlaz
Copy link
Contributor Author

/summary:run

dm-vodopyanov
dm-vodopyanov previously approved these changes Mar 2, 2021
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirlaz
Copy link
Contributor Author

@kbobrovs, could you please have a look/approve?

@vladimirlaz
Copy link
Contributor Author

@kbobrovs, @dm-vodopyanov could you please have a look?

@vladimirlaz vladimirlaz merged commit 86b0e8d into intel:sycl Mar 6, 2021
@vladimirlaz vladimirlaz deleted the jit_cache_1 branch April 23, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants