Skip to content

[WIP] [DO NOT MERGE] add std::span support #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[WIP] [DO NOT MERGE] add std::span support #3509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
556b15d
[SYCL] Uplift SYCL runtime standard to C++17
vladimirlaz Mar 30, 2021
c34b3d9
checkpoint - stdlib version issues
cperkinsintel Apr 7, 2021
96418c0
Merge branch 'vlazarev-uplift' into cperkins-std-span-support
cperkinsintel Apr 7, 2021
67ecd43
working. Needs tests and decisions on file mgmt
cperkinsintel Apr 7, 2021
7f79fa4
clean up and comments
cperkinsintel Apr 7, 2021
6a51484
more comment removal
cperkinsintel Apr 7, 2021
bd9646f
adding unit tests and changing namespace. Still requires cleanup
cperkinsintel Apr 9, 2021
f0dea36
review feedback, and more test changes due to C++17 requirement
cperkinsintel Apr 12, 2021
84e1278
resolved merge conflicts
cperkinsintel Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.14)

project(sycl-solution)
# Requirements
set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
option(SYCL_ENABLE_WERROR "Treat all warnings as errors in SYCL project" OFF)
Expand Down
2 changes: 1 addition & 1 deletion sycl/cmake/modules/AddSYCLUnitTest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ macro(add_sycl_unittest test_dirname link_variant)
# CXX_STANDARD_REQUIRED makes CXX_STANDARD a hard requirement.
set_target_properties(${test_dirname}
PROPERTIES
CXX_STANDARD 14
CXX_STANDARD 17
CXX_STANDARD_REQUIRED ON
)
endmacro()
Expand Down
Loading