Skip to content

[SYCL] Allow __failed_assertion to support libstdc++-11 #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 2, 2021

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented May 18, 2021

Signed-off-by: gejin [email protected]

@jinge90
Copy link
Contributor Author

jinge90 commented May 18, 2021

/summary:run

@elizabethandrews
Copy link
Contributor

Does this require review or is it still WIP?

@jinge90
Copy link
Contributor Author

jinge90 commented May 18, 2021

Does this require review or is it still WIP?

Sorry for the confusion, it is still WIP.
Thanks very much.

@jinge90 jinge90 changed the title [SYCL][Draft] Allow __failed_assertion to support libstdc++-11 [SYCL][WIP] Allow __failed_assertion to support libstdc++-11 May 18, 2021
@elizabethandrews
Copy link
Contributor

Does this require review or is it still WIP?

Sorry for the confusion, it is still WIP.
Thanks very much.

No problem!

@jinge90
Copy link
Contributor Author

jinge90 commented May 19, 2021

/summary:run

@jinge90 jinge90 requested a review from AaronBallman May 20, 2021 07:13
@jinge90
Copy link
Contributor Author

jinge90 commented May 20, 2021

/summary:run

@jinge90 jinge90 changed the title [SYCL][WIP] Allow __failed_assertion to support libstdc++-11 [SYCL] Allow __failed_assertion to support libstdc++-11 May 20, 2021
@jinge90
Copy link
Contributor Author

jinge90 commented May 21, 2021

/summary:run

Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits.

Signed-off-by: gejin <[email protected]>
@jinge90
Copy link
Contributor Author

jinge90 commented May 26, 2021

/summary:run

Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor nits with the implementation, but you should add test coverage for the change as well.

Signed-off-by: gejin <[email protected]>
Signed-off-by: gejin <[email protected]>
@jinge90
Copy link
Contributor Author

jinge90 commented May 28, 2021

Just a few minor nits with the implementation, but you should add test coverage for the change as well.

Hi, @AaronBallman
I have added 2 lit tests for __failed_assertion.
Thanks very much.

@jinge90 jinge90 requested a review from AaronBallman May 28, 2021 06:08
Signed-off-by: gejin <[email protected]>
@jinge90
Copy link
Contributor Author

jinge90 commented May 28, 2021

/summary:run

@jinge90
Copy link
Contributor Author

jinge90 commented Jun 1, 2021

/summary:run

@jinge90
Copy link
Contributor Author

jinge90 commented Jun 1, 2021

/summary:run

@jinge90 jinge90 requested a review from AaronBallman June 2, 2021 11:15
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bader bader merged commit 79c460c into intel:sycl Jun 2, 2021
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Jun 4, 2021
* sycl: (320 commits)
  [SYCL] Silence a "local variable is initialized but not referenced" warning; NFC (intel#3870)
  [SYCL] Improve SYCL_DEVICE_ALLOWLIST (intel#3826)
  [SPIR-V] Change return value of mapType function (intel#3871)
  [SYCL] Fix post-commit failure in handler.hpp from unused-parameters. (intel#3874)
  [Driver][SYCL] Do not imply defaultlib msvcrt for Linux based driver on Windows (intel#3827)
  [SYCL] Unique stable name rebase (intel#3835)
  [SYCL] Align behavior of empty command groups with SYCL2020 (intel#3822)
  [SYCL][ESIMD] Make typenames and constants consistent with SYCL API style. (intel#3850)
  [SYCL] Allow __failed_assertion to support libstdc++-11 (intel#3774)
  [SYCL] Refactor stream class handing implementation (intel#3646)
  [SYCL] Fix syntax error introduced in intel#3401 (intel#3861)
  [SYCL] SYCL 2020 sub_group algorithms (intel#3786)
  [Buildbot][NFC] Add option to use LLD as linker (intel#3866)
  Revert "Emit correct location lists with basic block sections."
  [SPIRITTAnnotations] Fix debug info for ITT calls. (intel#3829)
  [SYCL][Doc] Fix build of Sphinx docs (intel#3863)
  [SYCL][FPGA][NFC] Tidy up intel_fpga_reg codegen test (intel#3810)
  [CODEOWNERS] Fix SPIRITTAnnnotations tests ownership (intel#3859)
  [SYCL][ESIMD] Host-compile simd.cpp test, fix errors & warnings. (intel#3846)
  [SYCL] Store pointers to memory allocations instead of iterators (intel#3860)
  ...
@jinge90 jinge90 deleted the glibcxx_assert_support branch June 10, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants