Skip to content

[SYCL] Add SYCL 2020 buffer and vec function byte_size() #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 16, 2021

Conversation

nawrinsu
Copy link
Contributor

No description provided.

@nawrinsu nawrinsu requested review from turinevgeny and a team as code owners July 19, 2021 14:35
@nawrinsu nawrinsu requested a review from rbegam July 19, 2021 14:35
@nawrinsu nawrinsu force-pushed the byte_size branch 2 times, most recently from fd3540b to 9a2b902 Compare July 19, 2021 14:50
@bader bader changed the title [SYCL] Add SYCL2020 buffer and vec function byte_size() [SYCL] Add SYCL 2020 buffer and vec function byte_size() Jul 19, 2021
@nawrinsu nawrinsu requested a review from s-kanaev August 5, 2021 14:23
Copy link
Contributor

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests for new functions?
Also you can add checks for deprecation messages in sycl/test/warnings/sycl_2020_deprecations.cpp.

@nawrinsu
Copy link
Contributor Author

PR link for test - intel/llvm-test-suite#403

@vladimirlaz
Copy link
Contributor

@turinevgeny could you please review as the code owner?

@vladimirlaz vladimirlaz requested a review from bader August 16, 2021 09:10
@vladimirlaz vladimirlaz merged commit 282d1de into intel:sycl Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants