Skip to content

[SYCL][libclc] Fix remangled libclc files not being correctly installed #4372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

steffenlarsen
Copy link
Contributor

The remangled libclc bitcode files were not being moved into the install directory. These changes ensure that the libclc variants are correctly configured to be copied into the install directory, if remangled variants are enabled.

The remangled libclc bitcode files were not being moved into the install
directory. These changes ensure that the libclc variants are correctly
configured to be copied into the install directory, if remangled
variants are enabled.

Signed-off-by: Steffen Larsen <[email protected]>
@steffenlarsen steffenlarsen requested a review from bader as a code owner August 19, 2021 10:57
Copy link
Contributor

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change should fix massive E2E tests and benchmark failures in CI.

@bader bader added cuda CUDA back-end libclc libclc project related issues hip Issues related to execution on HIP backend. labels Aug 19, 2021
@bader bader merged commit 52101af into intel:sycl Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end hip Issues related to execution on HIP backend. libclc libclc project related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants