[SYCL][ESIMD][EMU] pi_esimd_cpu bringing up with CM library (2nd) #4430
Conversation
- This PR is for a change set that invokes CM functionalities for ESIMD_CPU - initializing CM_EMU module, launching kernel, and accessing CM-managed resources like buffer, etc. CM_EMU library is downloaded as pre-built package from open-source CM github repo (https://github.com/intel/cm-cpu-emulation.git) under Linux environment Co-authored-by: Romanov Vlad <[email protected]> Co-authored-by: kbobrovs <[email protected]>
- '--enable-esimd-cpu-emulation' for configure.py enables ESIMD_CPU - ESIMD_CPU build requires header files from libva-dev/devel package.
dongkyunahn-intel
requested review from
bader,
DenisBakhvalov,
kbobrovs,
kychendev,
smaslov-intel and
a team
as code owners
dongkyunahn-intel
changed the title
| @@ -181,7 +181,7 @@ def main(): | |||
| parser.add_argument("--rocm", action='store_true', help="switch from OpenCL to ROCm") | |||
| parser.add_argument("--rocm-platform", type=str, choices=['AMD', 'NVIDIA'], default='AMD', help="choose ROCm backend") | |||
| parser.add_argument("--arm", action='store_true', help="build ARM support rather than x86") | |||
| parser.add_argument("--disable-esimd-cpu", action='store_true', help="build without ESIMD_CPU support") | |||
| parser.add_argument("--enable-esimd-cpu-emulation", action='store_true', help="build with ESIMD_CPU emulation support") | |||
There was a problem hiding this comment.
should it rather be
| parser.add_argument("--enable-esimd-cpu-emulation", action='store_true', help="build with ESIMD_CPU emulation support") | |
| parser.add_argument("--enable-esimd-cpu-emulation", action='store_false', help="build with ESIMD_CPU emulation support") |
?
There was a problem hiding this comment.
As far as I know, store_true means 'True' will be applied to 'enable-esimd-cpu-emulation' member variable with --enable-esimd-cpu-emuation. store_false means 'False' for the variable. This is same for other plugins that are enabled with similar command line option like CUDA - Line 180.
There was a problem hiding this comment.
store_true will set the variable to true when the option is available, otherwise it will remain default (BTW, default=False might be needed). Isn't that the intent?
There was a problem hiding this comment.
Yes. I verified that current code works as the intent.
- Without
--enable-esimd-cpu-emulationcommand line argument,libpi_esimd_cpu.sois not generated - With the command line argument,
libpi_esimd_cpu.sois generated
The store_true option automatically creates a default value of False. - https://stackoverflow.com/questions/8203622/argparse-store-false-if-unspecified
There was a problem hiding this comment.
Please, update https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md document with instructions how to build, test and use DPC++ with ESIMD CPU back-end support. Specify additional software requirements for building and using new back-end and known limitations of the back-end.
- ESIMD CPU emulation is added
- File name is changed in open-source CM_EMU git repo as there was mismatch between version number in archive name and extracted directory name
Co-authored-by: Alexey Bader <[email protected]>
- For development environments where pre-built binary package download & installation is not allowed - Prerequisites : libva and its header files, libffi
| * libdrm | ||
| * libdrm-devel | ||
| * libva | ||
| * libva-devel |
There was a problem hiding this comment.
it would be good to specify which of those are needed to run emulation. I suppose *dev are not needed?
This PR is for bringing back change set from PR#4011 without build-dependency on libva-dev/level package. (
<va/va.h>file)--enable-esimd-cpu-emulationcommand line argument forconfigure.pyscript enables ESIMD_CPU.