Skip to content

[SYCL] Make Level-Zero interop API SYCL-2020 compliant for queue, event, and kernel_bundle(was program). #4512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 13, 2021

Conversation

smaslov-intel
Copy link
Contributor

Signed-off-by: Sergey V Maslov [email protected]

@smaslov-intel smaslov-intel requested a review from a team as a code owner September 7, 2021 23:15
alexbatashev
alexbatashev previously approved these changes Sep 8, 2021
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests should be eventually updated as well, I think: https://github.com/intel/llvm-test-suite/tree/intel/SYCL/Basic/interop

@bader
Copy link
Contributor

bader commented Sep 8, 2021

These tests should be eventually updated as well, I think: https://github.com/intel/llvm-test-suite/tree/intel/SYCL/Basic/interop

@smaslov-intel, fix sycl/test/basic_tests/interop-level-zero-2020.cpp as well.
Please, do not modify file permissions for sycl/include/CL/sycl/backend/level_zero.hpp.

@bader
Copy link
Contributor

bader commented Sep 8, 2021

@smaslov-intel, please, sync with the tip of the branch. There are merge conflicts.

Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
@smaslov-intel
Copy link
Contributor Author

Failed Tests (4):
[2021-09-08T21:04:17.580Z] SYCL :: OnlineCompiler/online_compiler_L0.cpp
[2021-09-08T21:04:17.580Z] SYCL :: Plugin/interop-level-zero-keep-ownership.cpp
[2021-09-08T21:04:17.580Z] SYCL :: Plugin/interop-level-zero.cpp
[2021-09-08T21:04:17.580Z] SYCL :: Regression/cache_test.cpp

The tests in Precommit testing failed due to these prior change: https://github.com/intel/llvm/pull/4432/files#diff-bad45c4e6d46c89d807c929b6adbffdb70993c102647c58b41fb0534e2195727

The tests need to be adjusted. @dm-vodopyanov : are you doing that?
It will also break existing customer's codes, is that acknowledged?

@smaslov-intel
Copy link
Contributor Author

The tests need to be adjusted. @dm-vodopyanov : are you doing that?

@dm-vodopyanov : ping
@bader : are you aware of this?

Signed-off-by: Sergey V Maslov <[email protected]>
@smaslov-intel
Copy link
Contributor Author

@alexbatashev , please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants