[SYCL] Use secondary queue in assert post-processing #4759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For submissions with a secondary queue the post-process lambda currently captures the secondary queue but does not pass it along. These changes uses the secondary queue if it is not a host queue. Signed-off-by: Steffen Larsen <[email protected]>
s-kanaev
approved these changes
Oct 14, 2021
Pre-commit doesn't cover the build with disabled assertions. |
vladimirlaz
approved these changes
Oct 14, 2021
The submit template with a secondary queue doesn't seem to have instantiated in testing, so the warning for unused lambda capture wasn't issued. #4744 added test that use secondary queue submits, so the warning was manifested. |
steffenlarsen
deleted the
steffen/queue_submit_secondary_fallback_assert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For submissions with a secondary queue the post-process lambda currently captures the secondary queue but does not pass it along. These changes uses the secondary queue if it is not a host queue.
Note: This should fix the current post-commit failures.