[SYCL] Fix the integration header generation for kernel with typedefs. #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
previously approved these changes
Aug 22, 2019
|
Will help to fix #130? |
Yes. |
|
Closes #130 |
|
@tfzhu, do you know why buildbot hasn't started builds for this PR? |
|
@tfzhu ping. Help plz. |
Added printing policy with the canonical types flag enabled to generation declarations of templated kernel function types and specializations of KernelInfo for kernel function types. Before this change for single_task/parallel_for<class kernel<T>> where T is type alias (typedef/using) in the integration header remained the alias without defining what it is. Example: //// SYCL code using type_t = int; template<type_t N> class kernel; single_task<class kernel<0>>(... //// generated integration header // This is auto-generated SYCL integration header. // Forward declarations of templated kernel function types: template <type_t N> class kernel; Signed-off-by: Alexey Voronov <[email protected]>
alexeyvoronov-intel
force-pushed
the
private/avoronov/kernel_name_with_typedefs
branch
from
25e975a to
0f88256
Compare
asavonic
previously approved these changes
Aug 27, 2019
|
@bader |
bader
approved these changes
Aug 27, 2019
alexeyvoronov-intel
deleted the
private/avoronov/kernel_name_with_typedefs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added printing policy with the canonical types flag enabled to
generation declarations of templated kernel function types and
specializations of KernelInfo for kernel function types.
Before this change for single_task/parallel_for<class kernel>
where T is type alias (typedef/using) in the integration header
remained the alias without defining what it is.
Example:
//// SYCL code
using type_t = int; template<type_t N> class kernel;
single_task<class kernel<0>>(...
//// generated integration header
// This is auto-generated SYCL integration header.
// Forward declarations of templated kernel function types:
template <type_t N> class kernel;
Signed-off-by: Alexey Voronov [email protected]