Skip to content

[SYCL][ESIMD][EMU] Preventing 'cmrt_dump.txt' generation from CM #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dongkyunahn-intel
Copy link
Contributor

  • CM library used by ESIMD_EMULATOR support generates 'cmrt_dump.txt'
    file for debugging

  • This patch prevents file generation

  • cmrt_dump.txt generated  #5379

- CM library used by ESIMD_EMULATOR support generates 'cmrt_dump.txt'
file for debugging

- This patch prevents file generation
@dongkyunahn-intel dongkyunahn-intel requested a review from a team as a code owner February 3, 2022 19:05
@dongkyunahn-intel
Copy link
Contributor Author

This patch removes following line, and CM library package is generated without debug support, which generates cmrt_dump.txt.

https://github.com/intel/cm-cpu-emulation/blob/3c9eb58b06b72d28de3015d23243f0fa594cdb31/common/emu_log.h#L35

@bader bader requested a review from pvchupin February 4, 2022 10:46
@bader
Copy link
Contributor

bader commented Feb 10, 2022

@pvchupin, could you take a look, please?

@pvchupin
Copy link
Contributor

It requires detailed explanation in PR description what's going on here and why this change is needed.
It looks like we may have design problem over the full stack?
Tagging @kbobrovs

Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented above.

@dongkyunahn-intel
Copy link
Contributor Author

@pvchupin ,

Until CM library package used by ESIMD_EMULATOR is provided as pre-built one, it needs to be built during intel/llvm toolchain build by downloading & building source files from https://github.com/intel/cm-cpu-emulation. The CMakeLists.txt file modified in this ticket takes care of CM library generation.

CM library package built during esimd_emulator PI module build is generated as debug build. This build configuration happens to leave empty cmrt_dump.txt file after kernel execution (#5379). As it could take a while for open-source CM library to be updated to prevent debug file generation, I applied online-patching for CM library to be built as Release build. This PR is for the online-patching.

@lsatanov
Copy link
Contributor

I'm to release CM EMU with this issue fixed shortly, so this change will not be needed.

@dongkyunahn-intel
Copy link
Contributor Author

I'm to release CM EMU with this issue fixed shortly, so this change will not be needed.

I'll close this PR when open-source CM EMU is updated.

@pvchupin
Copy link
Contributor

@dongkyunahn-intel , @lsatanov thank you. That would be the best approach imo.

@lsatanov
Copy link
Contributor

lsatanov commented Feb 18, 2022

@dongkyunahn-intel
Copy link
Contributor Author

PR is posted for using up-to-date opensource CM_EMU - #5668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants