[SYCL][DOC] Update device global design shadowing #5525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the design for device global variables for variables that are "shadowed" in an unnamed namespace. This change was suggested by @Fznamznon because it allows us to reuse existing machinery we have for handling shadowed `specialization_id` variables.
Fznamznon
approved these changes
Feb 10, 2022
Comment on lines
+357
to
+358
| footer we use for specialization constants. See the [specialization constant | ||
| design document][5] for more details on this topic. |
There was a problem hiding this comment.
This is a bit confusing that SpecializationConstants.md document doesn't actually describe this topic (only #3331 does). Tagging @AlexeySachkov .
bader
changed the title
bader
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the design for device global variables for variables that are
"shadowed" in an unnamed namespace. This change was suggested by
@Fznamznon because it allows us to reuse existing machinery we have
for handling shadowed
specialization_idvariables.