[SYCL][L0] Set minimum pooled USM allocation size on device to 512 #5635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaslov-intel
suggested changes
Feb 23, 2022
bader
requested changes
Feb 24, 2022
There was a problem hiding this comment.
Please, update PR title according to the contribution guide.
In particular:
from https://llvm.org/docs/DeveloperPolicy.html#commit-messages
The title should be concise. Because all commits are emailed to the list with the first line as the subject, long titles are frowned upon. Short titles also look better in git log.
When the changes are restricted to a specific part of the code (e.g. a back-end or optimization pass), it is customary to add a tag to the beginning of the line in square brackets. For example, “[SCEV] …” or “[OpenMP] …”. This helps email filters and searches for post-commit reviews.
"lj35332" doesn't say much to me.
Please, add tags to the PR title.
rdeodhar
changed the title
smaslov-intel
approved these changes
Feb 24, 2022
bader
changed the title
bader
approved these changes
Feb 24, 2022
vladimirlaz
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change increases minimum allocation size on Device to 512 to match granularity of newer GPUs. It also improves env var processing and corrects the documentation.