Skip to content

[SYCL][DOC] Enable SYCL_EXT_ONEAPI_PROPERTIES extension #5693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

steffenlarsen
Copy link
Contributor

These changes adds the definition of the SYCL_EXT_ONEAPI_PROPERTIES feature macro and moves the corresponding proposal to experimental support.

These changes adds the definition of the SYCL_EXT_ONEAPI_PROPERTIES
feature macro and moves the corresponding proposal to experimental
support.

Signed-off-by: Steffen Larsen <[email protected]>
@steffenlarsen steffenlarsen requested review from a team as code owners March 1, 2022 10:25
@steffenlarsen steffenlarsen requested a review from s-kanaev March 1, 2022 10:25
s-kanaev
s-kanaev previously approved these changes Mar 1, 2022
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlueck
Copy link
Contributor

gmlueck commented Mar 1, 2022

Can you also update the "Status" section of the API specification with the wording proposed in the document template in #5663:

This is an experimental extension specification, intended to provide early
access to features and gather community feedback.  Interfaces defined in this
specification are implemented in {dpcpp}, but they are not finalized and may
change incompatibly in future versions of {dpcpp} without prior notice.
*Shipping software products should not rely on APIs defined in this
specification.*

You will also need to add this line near the top (as shown in the template):

:dpcpp: pass:[DPC++]

Signed-off-by: Steffen Larsen <[email protected]>
@bader
Copy link
Contributor

bader commented Mar 1, 2022

@steffenlarsen, the failure below doesn't seem to be related to this change, so I'm going to merge this PR, but could you please, make sure that we have a tracker raised for that, please?

Failed Tests (1):
SYCL :: Plugin/level_zero_batch_event_status.cpp

@bader bader merged commit 1984e74 into intel:sycl Mar 1, 2022
@steffenlarsen steffenlarsen deleted the steffen/define_compile_time_props_macro branch December 6, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants