Skip to content

[Testing][SYCL] Do not decompose structs with pointers #5814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions clang/lib/Sema/SemaSYCL.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1825,11 +1825,6 @@ class SyclKernelDecompMarker : public SyclKernelFieldHandler {
return true;
}

bool handlePointerType(FieldDecl *, QualType) final {
CollectionStack.back() = true;
return true;
}

bool enterStruct(const CXXRecordDecl *, FieldDecl *, QualType) final {
CollectionStack.push_back(false);
return true;
Expand Down
1 change: 1 addition & 0 deletions clang/test/CodeGenSYCL/inheritance.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// RUN: %clang_cc1 -fsycl-is-device -triple spir64-unknown-unknown -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s
// XFAIL: *

#include "Inputs/sycl.hpp"

Expand Down
1 change: 1 addition & 0 deletions clang/test/CodeGenSYCL/pointers-in-structs.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// RUN: %clang_cc1 -fsycl-is-device -triple spir64-unknown-unknown -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s
// XFAIL: *

// This test checks that compiler generates correct address spaces for pointer
// kernel arguments that are wrapped by struct.
Expand Down
1 change: 1 addition & 0 deletions clang/test/CodeGenSYCL/pointers-int-header.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// RUN: %clang_cc1 -fsycl-is-device -triple spir64-unknown-unknown -fsycl-int-header=%t.h %s -o %t.out
// RUN: FileCheck -input-file=%t.h %s
// XFAIL: *

// This test checks the integration header generated when:
// 1. Kernel argument is a pointer.
Expand Down
1 change: 1 addition & 0 deletions clang/test/CodeGenSYCL/struct_kernel_param.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// RUN: %clang_cc1 -fsycl-is-device -triple spir64-unknown-unknown -fsycl-int-header=%t.h %s -o %t.out
// RUN: FileCheck -input-file=%t.h %s
// XFAIL: *

// CHECK: const kernel_param_desc_t kernel_signatures[] = {
// CHECK-NEXT: //--- _ZTSZZ5test0vENKUlRN2cl4sycl7handlerEE_clES2_E8MyKernel
Expand Down
1 change: 1 addition & 0 deletions clang/test/SemaSYCL/array-kernel-param.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// RUN: %clang_cc1 -fsycl-is-device -internal-isystem %S/Inputs -ast-dump -sycl-std=2020 %s | FileCheck %s
// XFAIL: *

// This test checks that compiler generates correct kernel arguments for
// arrays, Accessor arrays, and structs containing Accessors.
Expand Down
1 change: 1 addition & 0 deletions clang/test/SemaSYCL/built-in-type-kernel-arg.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// RUN: %clang_cc1 -fsycl-is-device -internal-isystem %S/Inputs -sycl-std=2020 -ast-dump %s | FileCheck %s
// XFAIL: *

// This test checks that compiler generates correct initialization for arguments
// that have struct or built-in type inside the OpenCL kernel
Expand Down
1 change: 1 addition & 0 deletions clang/test/SemaSYCL/inheritance.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// RUN: %clang_cc1 -fsycl-is-device -ast-dump %s | FileCheck %s
// XFAIL: *

#include "Inputs/sycl.hpp"

Expand Down
1 change: 1 addition & 0 deletions clang/test/SemaSYCL/union-kernel-param2.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// RUN: %clang_cc1 -fsycl-is-device -ast-dump %s | FileCheck %s
// XFAIL: *

// This test checks that compiler generates correct kernel arguments for
// a struct-with-an-array-of-unions and a array-of-struct-with-a-union.
Expand Down