Skip to content

[SYCL] Add SYCL 2020 spec constants design doc #5842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexeySachkov
Copy link
Contributor

No description provided.

@AlexeySachkov AlexeySachkov requested review from a team as code owners March 21, 2022 08:05
@AlexeySachkov
Copy link
Contributor Author

This is a re-submit of #3331:

  • moved the file to a new location
  • adjusted a few other docs to point to the correct spec constants design
  • made minor adjustments to FE section saying that kernel_handler argument is always generated

bader
bader previously approved these changes Mar 21, 2022
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexeySachkov AlexeySachkov requested a review from bader March 24, 2022 16:53
@AlexeySachkov
Copy link
Contributor Author

buildbot/sycl-win-x64-pr Pending — Build started.

This check actually passed two days ago if you click details link. @bader, I believe we can merge this

@bader bader merged commit 8ec9755 into intel:sycl Apr 4, 2022
@AlexeySachkov AlexeySachkov deleted the private/asachkov/sycl-2020-spec-constants-design branch May 22, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants