[SYCL][Doc] Clarify availability of get_property() #5992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension previously said that certain calls to get_property() must produce a compiler error, which could be satisfied by calling static_assert(). A static_assert()-based solution throws errors any time the get_property<> template is instantiated, which can lead to some surprising errors in user code. Stating that get_property() must only be available when the property type exists in the property list has two advantages: 1) Users can more easily reason about when errors will be thrown and how to avoid those errors. 2) Users can rely on all implementations to have the same error behavior. Signed-off-by: John Pennycook <[email protected]>
Pennycook
added
the
spec extension
gmlueck
approved these changes
Apr 8, 2022
steffenlarsen
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension previously said that certain calls to get_property()
must produce a compiler error, which could be satisfied by calling
static_assert(). A static_assert()-based solution throws errors
any time the get_property<> template is instantiated, which can
lead to some surprising errors in user code.
Stating that get_property() must only be available when the property
type exists in the property list has two advantages:
Users can more easily reason about when errors will be thrown and
how to avoid those errors.
Users can rely on all implementations to have the same error
behavior.
Signed-off-by: John Pennycook [email protected]