[SYCL] Restrict collection of information for optimization record #6170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collect information for optimization record only if the optmization record is saved by user (i.e. -fsave-optimization-record or -opt-record-file is passed). This patch prevents unecessary calls to opt-report handlers when not required. I couldn't think of a way to add a test for this since there is no change in output. Information is collected when the flag is passed and emitted into optimization record. Information is no longer collected when there is no optimization record. This is a follow up to intel#3492 and intel#3730 Signed-off-by: Elizabeth Andrews <[email protected]>
|
ping |
1 similar comment
|
ping |
mdtoguchi
approved these changes
May 19, 2022
smanna12
approved these changes
May 19, 2022
|
@intel/llvm-gatekeepers PR is ready for review and merge |
yinyangsx
pushed a commit
to yinyangsx/llvm
that referenced
this pull request
May 25, 2022
…tel#6170) Collect information for optimization record only if the optmization record is saved by user (i.e. -fsave-optimization-record or -opt-record-file is passed). This patch prevents unecessary calls to opt-report handlers when not required. I couldn't think of a way to add a test for this since there is no change in output. Information is collected when the flag is passed and emitted into optimization record. Information is no longer collected when there is no optimization record. This is a follow up to intel#3492 and intel#3730 Signed-off-by: Elizabeth Andrews <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect information for optimization record only if the optmization
record is saved by user (i.e. -fsave-optimization-record or
-opt-record-file is passed). This patch prevents unecessary calls
to opt-report handlers when not required.
I couldn't think of a way to add a test for this since there is no
change in output. Information is collected when the flag is passed
and emitted into optimization record. Information is no longer
collected when there is no optimization record.
This is a follow up to #3492
and #3730
Signed-off-by: Elizabeth Andrews [email protected]