[SYCL] Follow-up for #7599 - return PI_ERROR_INVALID_VALUE after assert #7764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Dec 13, 2022
| @@ -2534,9 +2534,13 @@ pi_result cuda_piextQueueCreate(pi_context Context, pi_device Device, | |||
| assert(Properties); | |||
| // Expect flags mask to be passed first. | |||
| assert(Properties[0] == PI_QUEUE_FLAGS); | |||
There was a problem hiding this comment.
Do you need to keep these asserts?
There was a problem hiding this comment.
I've seen the same pattern in another place in one of those. Also, I'd rather have it abort in debug to speed up any potential analysis.
v-klochkov
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.