Skip to content

[SYCL] Fix accessor fill for unsupported patterns #8845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

steffenlarsen
Copy link
Contributor

Currently most of the PI backends have similar pattern limitations as OpenCL, i.e. only certain sizes of patterns are supported. This is not currently being considered by the implementation however, potentially causing the backend calls to fail. This commit makes the runtime fall back to a fill kernel if the pattern has an unsupported size.

Currently most of the PI backends have similar pattern limitations as
OpenCL, i.e. only certain sizes of patterns are supported. This is not
currently being considered by the implementation however, potentially
causing the backend calls to fail. This commit makes the runtime fall
back to a fill kernel if the pattern has an unsupported size.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen requested a review from a team as a code owner March 28, 2023 22:41
@steffenlarsen steffenlarsen requested a review from bso-intel March 28, 2023 22:41
@steffenlarsen steffenlarsen temporarily deployed to aws March 29, 2023 04:23 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 29, 2023 08:41 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov requested a review from a team March 30, 2023 09:44
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 7f49367 into intel:sycl Mar 31, 2023
@bader
Copy link
Contributor

bader commented Mar 31, 2023

abi/sycl_symbols_windows.dump fails on Windows.

FAIL: SYCL :: abi/sycl_symbols_windows.dump (13 of 446)
******************** TEST 'SYCL :: abi/sycl_symbols_windows.dump' FAILED ********************
Script:
--
: 'RUN: at line 6';   env LLVM_BIN_PATH=D:/github/_work/llvm/llvm/build/bin/ "C:\Python311\python.exe" D:/github/_work/llvm/llvm/src/sycl/tools//abi_check.py --mode check_symbols --reference D:\github\_work\llvm\llvm\src\sycl\test\abi\sycl_symbols_windows.dump D:/github/_work/llvm/llvm/build/bin//sycl6.dll
--
Exit Code: 4[294](https://github.com/intel/llvm/actions/runs/4571286347/jobs/8069438775#step:10:295)967[295](https://github.com/intel/llvm/actions/runs/4571286347/jobs/8069438775#step:10:296)

Command Output (stdout):
--
$ ":" "RUN: at line 6"
note: command had no output on stdout or stderr
$ "env" "LLVM_BIN_PATH=D:/github/_work/llvm/llvm/build/bin/" "C:\Python311\python.exe" "D:/github/_work/llvm/llvm/src/sycl/tools//abi_check.py" "--mode" "check_symbols" "--reference" "D:\github\_work\llvm\llvm\src\sycl\test\abi\sycl_symbols_windows.dump" "D:/github/_work/llvm/llvm/build/bin//sycl6.dll"
# command output:
There are new symbols in the new library. It is a non-breaking change. Refer to sycl/doc/developer/ABIPolicyGuide.md for further instructions.
The following symbols are new to the object file:

?isBackendSupportedFillSize@handler@_V1@sycl@@CA_N_K@Z

error: command failed with exit status: 0xffffffff

--

steffenlarsen added a commit to steffenlarsen/llvm that referenced this pull request Mar 31, 2023
This commit adds a missing Windows symbol to the symbols dump after
intel#8845.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen
Copy link
Contributor Author

abi/sycl_symbols_windows.dump fails on Windows.

FAIL: SYCL :: abi/sycl_symbols_windows.dump (13 of 446)
******************** TEST 'SYCL :: abi/sycl_symbols_windows.dump' FAILED ********************
Script:
--
: 'RUN: at line 6';   env LLVM_BIN_PATH=D:/github/_work/llvm/llvm/build/bin/ "C:\Python311\python.exe" D:/github/_work/llvm/llvm/src/sycl/tools//abi_check.py --mode check_symbols --reference D:\github\_work\llvm\llvm\src\sycl\test\abi\sycl_symbols_windows.dump D:/github/_work/llvm/llvm/build/bin//sycl6.dll
--
Exit Code: 4[294](https://github.com/intel/llvm/actions/runs/4571286347/jobs/8069438775#step:10:295)967[295](https://github.com/intel/llvm/actions/runs/4571286347/jobs/8069438775#step:10:296)

Command Output (stdout):
--
$ ":" "RUN: at line 6"
note: command had no output on stdout or stderr
$ "env" "LLVM_BIN_PATH=D:/github/_work/llvm/llvm/build/bin/" "C:\Python311\python.exe" "D:/github/_work/llvm/llvm/src/sycl/tools//abi_check.py" "--mode" "check_symbols" "--reference" "D:\github\_work\llvm\llvm\src\sycl\test\abi\sycl_symbols_windows.dump" "D:/github/_work/llvm/llvm/build/bin//sycl6.dll"
# command output:
There are new symbols in the new library. It is a non-breaking change. Refer to sycl/doc/developer/ABIPolicyGuide.md for further instructions.
The following symbols are new to the object file:

?isBackendSupportedFillSize@handler@_V1@sycl@@CA_N_K@Z

error: command failed with exit status: 0xffffffff

--

Seems like Windows wants that to be a symbol, for some reason. #8900 adds it to the symbol check.

dm-vodopyanov pushed a commit that referenced this pull request Mar 31, 2023
This commit adds a missing Windows symbol to the symbols dump after
#8845.

Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants