Skip to content

[SYCL] Add marray support to integer built-in functions #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 31, 2023
Merged

[SYCL] Add marray support to integer built-in functions #8861

merged 4 commits into from
Mar 31, 2023

Conversation

dm-vodopyanov
Copy link
Contributor

This patch adds support of sycl::marray to integer built-in functions (SYCL 2020 spec, Table 178).

@dm-vodopyanov
[SYCL] Add marray support to integer built-in functions
91f1801 
This patch adds support of sycl::marray to integer built-in functions
(SYCL 2020 spec, Table 178).
@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner March 29, 2023 16:15
@dm-vodopyanov dm-vodopyanov requested review from steffenlarsen and a team March 29, 2023 16:15
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws March 29, 2023 17:09 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws March 29, 2023 19:13 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws March 30, 2023 11:39 — with GitHub Actions Inactive
AlexeySachkov
AlexeySachkov approved these changes Mar 30, 2023
View reviewed changes
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws March 30, 2023 12:57 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws March 30, 2023 15:00 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws March 30, 2023 16:15 — with GitHub Actions Inactive
@dm-vodopyanov
Copy link
Contributor Author

Unrelated to this patch:

Failed Tests (2):
SYCL :: AtomicRef/atomic_memory_order_acq_rel.cpp
SYCL :: GroupAlgorithm/reduce_sycl2020.cpp

steffenlarsen
steffenlarsen approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wonder if we could eventually consolidate some of the macros, but I think that would be a bigger refactoring.

@dm-vodopyanov dm-vodopyanov merged commit c274f40 into intel:sycl Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dm-vodopyanov @AlexeySachkov @steffenlarsen