[SYCL] Add a partial profiling workaround for acc devices #9062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent fixes to command submit profiling info, queue profiling is no longer supported on devices with OpenCL version < 2.1. This primarily affects applications on accelerator devices. The full solution would be to provide a fallback implementation of profiling information that is less precise but does not require querying device time. As a temporary workaround, this patch allows to create an accelerator queue with profiling despite the lack of queue_profiling aspect and instead throw an error if submit profiling info is requested.
steffenlarsen
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent fixes to command submit profiling info, queue profiling is no longer supported on devices with OpenCL version < 2.1. This primarily affects applications on accelerator devices. The full solution would be to provide a fallback implementation of profiling information that is less precise but does not require querying device time. As a temporary workaround, this patch allows to create an accelerator queue with profiling despite the lack of queue_profiling aspect and instead throw an error if submit profiling info is requested.