[SYCL][CUDA] Improve function to guess local work size more efficiently. #9787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e number for ranage diementsions.
mmoadeli
changed the title
steffenlarsen
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
I think this looks good. @jchlanda - Would you mind sanity-checking as well?
sycl/plugins/cuda/pi_cuda.cpp
Outdated
| // When global_work_size[0] is prime threadPerBlock[0] will later computed as | ||
| // 1, which is not efficient configuration. In such case we use | ||
| // global_work_size[0] + 1 to compute threadPerBlock[0]. | ||
| int x_global_work_size = (isPrime(global_work_size[0]) && |
There was a problem hiding this comment.
Nit; I would like this name to be a little more descriptive.
There was a problem hiding this comment.
thanks @steffenlarsen , done.
jchlanda
approved these changes
Jun 13, 2023
fineg74
pushed a commit
to fineg74/llvm
that referenced
this pull request
Jun 15, 2023
…ly. (intel#9787) * The `threadsPerBlock` values computed by `guessLocalWorkSize` are not the most optimal values. In particular the `threadsPerBlock` for `Y` and `Z` were much below the possible values. * When Y/Z values of range are prime a very poor performance is witnessed as shown in the associated [issue](intel#8018) * This PR compute `threadsPerBlock` for X/Y/Z to reduce corresponding `BlocksPerGrid` values. * Below presents the output of the code in associated issue without the changes in this PR. Device = NVIDIA GeForce GTX 1050 Ti N, elapsed(ms) - 1009,4.61658 - 2003,45.6869 - 3001,67.5192 - 4001,88.1543 - 5003,111.338 - 6007,132.848 - 7001,154.697 - 8009,175.452 - 9001,196.237 - 10007,219.39 - 1000,4.59423 - 2000,4.61525 - 3000,4.61935 - 4000,4.62526 - 5000,4.64623 - 6000,4.78904 - 7000,8.92251 - 8000,8.97263 - 9000,9.06992 - 10000,9.03802 * And below shows the output with the PR's updates Device = NVIDIA GeForce GTX 1050 Ti N, elapsed(ms) - 1009,4.58252 - 2003,4.60139 - 3001,3.47269 - 4001,3.62314 - 5003,4.15179 - 6007,7.07976 - 7001,7.49027 - 8009,8.00097 - 9001,9.08756 - 10007,8.0005 - 1000,4.56335 - 2000,4.60376 - 3000,4.76395 - 4000,4.63283 - 5000,4.64732 - 6000,4.63936 - 7000,8.97499 - 8000,8.9941 - 9000,9.01531 - 10000,9.00935
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
threadsPerBlockvalues computed byguessLocalWorkSizeare not the most optimal values. In particular thethreadsPerBlockforYandZwere much below the possible values.When Y/Z values of range are prime a very poor performance is witnessed as shown in the associated issue
This PR compute
threadsPerBlockfor X/Y/Z to reduce correspondingBlocksPerGridvalues.Below presents the output of the code in associated issue without the changes in this PR.
Device = NVIDIA GeForce GTX 1050 Ti
N, elapsed(ms)
Device = NVIDIA GeForce GTX 1050 Ti
N, elapsed(ms)