Copy weights file to epctx output directory #648
Draft
+45
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| const auto& sw_path_filename = shared_context_->shared_weights.external_weight_filename; | ||
| fs::path new_weights_file_path = session_context_.GetNewWeightsFilePath(sw_path_filename); | ||
| fs::path original_weights_path = session_context_.GetModelDirectory() / sw_path_filename; |
There was a problem hiding this comment.
This is not quite right. There's an ORT option for setting the weights path when for whatever reason the relative path between model and weight was altered from when the model was generated. For example if an initializer in the model has location = "weights.bin" then the file weights.bin is expected to be in the same folder as the model. If the weights are instead in "path\weights.bin" then session option ep.context_model_external_initializers_file_name MUST be set to "path".
In summary this needs a
fs::path GetWeightsDirectory() const {
return so_context_model_external_initializers_file_name.empty() ? GetModelDirectory() : so_so_context_model_external_initializers_file_name;
}There was a problem hiding this comment.
Based on yesterday's discussion we're not going to deal with context_model_external_initializers_file_name in this PR
|
|
||
| auto weight_path = session_context_.GetNewWeightsFilePath(sw.external_weight_filename); | ||
| if (!std::filesystem::exists(weight_path)) { | ||
| weight_path = session_context_.GetModelDirectory() / sw.external_weight_filename; |
ericcraw
force-pushed
the
model_weights_copy
branch
from
887f644 to
71479b3
Compare
ericcraw
force-pushed
the
model_weights_copy
branch
from
71479b3 to
aeccbc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.