Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

WIP: try with csi-test upgraded to 2.2.0 and change of #393 added #414

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

[[constraint]]
name = "github.com/kubernetes-csi/csi-test"
version = "2.1.0"
version = "2.2.0"

# We have to select the right version by name because of the "kubernetes-" prefix, dep doesn't
# recognize these as normal releases. Upstream is considering to change the tagging,
Expand Down
24 changes: 20 additions & 4 deletions test/e2e/storage/csi_volumes.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,20 +79,36 @@ var _ = Describe("PMEM Volumes", func() {
// We use 16Mi size volumes because this is the minimum size supported
// by xfs filesystem's allocation group
// Ref: http://man7.org/linux/man-pages/man8/mkfs.xfs.8.html
claimSize: "16Mi",
claimSize: "110Mi",
// VolumeIO test suite requires at least 102 MB volume.
}
},
}

// List of testSuites to be executed in below loop
var csiTestSuites = []func() testsuites.TestSuite{
// TODO: investigate how useful these tests are and enable them.

// testsuites.InitMultiVolumeTestSuite,
// === above test suite should come in new e2e release

testsuites.InitProvisioningTestSuite,
// testsuites.InitSnapshottableTestSuite,

// testsuites.InitSubPathTestSuite,
// testsuites.InitVolumeIOTestSuite,
// testsuites.InitVolumeModeTestSuite,
// === above line changes from "Ran 39 of 83 Specs in 89.985 sec, 39 Passed | 0 Failed | 0 Pending | 44 Skipped"
// === to "Ran 57 of 137 Specs in 925.305 sec, 55 Passed | 2 Failed | 0 Pending | 80 Skipped"
// === errors:
// === [It] should unmount if pod is force deleted while kubelet is down [Disruptive][Slow]
// No external address for pod pod-subpath-test-pmem-csi-dynamicpv-k559 on node pmem-csi-clear-govm-worker2
//
// === [It] should unmount if pod is gracefully deleted while kubelet is down [Disruptive][Slow]
// No external address for pod pod-subpath-test-pmem-csi-dynamicpv-q9sj on node pmem-csi-clear-govm-worker3
//
// Comments from review: Let's keep this disabled. Those tests are occasionally flaky also for Kubernetes, and
// they mostly test Kubernetes features, not so much the driver.

testsuites.InitVolumeIOTestSuite,
testsuites.InitVolumeModeTestSuite,
testsuites.InitVolumesTestSuite,
}

Expand Down