Node logging fixes #487
Merged
Node logging fixes #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because they are likely to be offline and if we have many child accounts, these logs will quickly fill up our drive
dora-gt
reviewed
Oct 31, 2019
| error!(target: "interledger-node", "No route found for outgoing account "); | ||
| // Don't log anything for failed route updates sent to child accounts | ||
| // because there's a good chance they'll be offline | ||
| if request.prepare.destination().scheme() != "peer" |
There was a problem hiding this comment.
I don't think this is required right now but this could be encapsulated and more understandable like
request.prepare.destination().is_scheme_peer()
// or
request.prepare.destination().is_scheme(Scheme::Peer)
dora-gt
approved these changes
Oct 31, 2019
the unit tests should only be testing the interface, not whether the call succeeds
emschwartz
force-pushed
the
es-fix-node
branch
from
2bc47c6 to
9ae65e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.