-
Notifications
You must be signed in to change notification settings - Fork 9
Dependency level control #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency level control #6
Conversation
Hello! Very interesting commits, thank you! I will be able to test them till the end of this week - I have some priority work right now. Some brief comments according to your commit:
|
Hey. Ok, I will change the semantic. Also I will change the default value of this new parameter to null, so we keep the original behaviour untouched. The global naming is more because I am planning to add this to an existing environment, just to avoid conflict. I have some ideas to make this more suitable without changing codes, I'll try to work on these when I have some free time. Cheers! |
When I named this global I thought that noone will create global named as application is. The same I have in my WebTerminal project, the application global is named Anyway, the purpose is only not to conflict with system or default globals - because If you have any conflicts, you can always install ClassExplorer into the new namespace, just create and import application to it, ClassExplorer won't loose any functionality and still be able to render classes from another namespace. Looking forward to hear what do you think about the global names :) Thank you for contributing! |
Personally, I also think that this will never conflict. Anyways I was just being cautious, maybe too much =P BTW, very nice work! It is a nice tool. |
I have taken a look of how it works - nice! But I found some things which I cannot understand - could you please answer the comments in your commits? Also, as all the code indented with And you have changed the mechanism how settings are stored to allow not only to work with Boolean values - that's cool and seems that it works fine. I just want to clarify which exception catches this Once all this things will be clarified, I'll merge the pull request. Thank you very much for contributing! |
Is just because this parameters is not being passed by all callers, I've changed to a better away tough.
I was trying to reduce as much as possible the view, but it seems not be working fine. This is removed.
The |
OK, great, the functionality you have added is useful - thank you very much!
I will fix the inheritance dependency level (I assume Thank you for your contribution! |
Dependency level control
I appreciate that, my pleasure to contribute! Thx for all the support. |
Hey,
I added an option to control the hierarchy level that is displayed on screen.
For some reason was falling with huge chain of classes.
Have a look if is interesting to add this
Cheers