Skip to content

Improve Lite Terminal shell integration #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Improve Lite Terminal shell integration #1505

merged 1 commit into from
Mar 11, 2025

Conversation

isc-bsaviano
Copy link
Contributor

@isc-bsaviano isc-bsaviano merged commit a9f5cbd into intersystems-community:master Mar 11, 2025
5 checks passed
@isc-bsaviano isc-bsaviano deleted the shell-int branch March 11, 2025 17:19
Tyriar
Tyriar reviewed Mar 11, 2025
View reviewed changes
src/commands/webSocketTerminal.ts
Comment on lines +223 to +224
// Set terminal properties
this._hideCursorWrite("\x1b]633;P;IsWindows=False\x07");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant fwiw as false is the default

Copy link

@Tyriar Tyriar Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I think we're going to keep HasRichCommandDetection regardless of whether we end up doing the API in microsoft/vscode#242897 as it's a very valuable signal for the dev and users to have. You would want to just write that all the time. Examples:

https://github.com/microsoft/vscode/blob/856dbe90b01e06f97ee16b4e3fbe8f63e93e4639/src/vs/workbench/contrib/terminal/common/scripts/shellIntegration.ps1#L127

https://github.com/microsoft/vscode/blob/856dbe90b01e06f97ee16b4e3fbe8f63e93e4639/src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-bash.sh#L201-L202

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments @Tyriar! I must have missed the HasRichCommandDetecton PR, I will adopt that sequence. While I have you attention, is there any chance that microsoft/vscode#179913 can be looked at again?

@isc-bsaviano isc-bsaviano mentioned this pull request Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar left review comments

@isc-rsingh isc-rsingh isc-rsingh approved these changes

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isc-bsaviano @Tyriar @isc-rsingh @gjsjohnmurray