Skip to content

Don't report error when deleting a local file that doesn't exist on the server #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Don't report error when deleting a local file that doesn't exist on the server #1555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/utils/documentIndex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,13 @@ function generateDeleteFn(wsFolderUri: vscode.Uri): (doc: string) => void {
api.deleteDocs([...docs]).then((data) => {
let failed = 0;
for (const doc of data.result) {
if (doc.status != "") {
// The document was not deleted, so log the error
if (doc.status != "" && !doc.status.includes("#16005:")) {
// The document was not deleted, so log the error.
// Error 16005 means we tried to delete a document
// that didn't exist. Since the purpose of this
// call was to delete the document, and at the
// end the document isn't there, we should ignore
// this error so the user doesn't get confused.
failed++;
outputChannel.appendLine(`${failed == 1 ? "\n" : ""}${doc.status}`);
}
Expand Down