Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

V5 Firebase SDK update #191

Merged
merged 2 commits into from
Jun 19, 2019
Merged

V5 Firebase SDK update #191

merged 2 commits into from
Jun 19, 2019

Conversation

mikehardy
Copy link
Collaborator

This updates the documentation to match invertase/react-native-firebase#2240

@mikehardy mikehardy mentioned this pull request Jun 16, 2019
Merged
6 tasks
@mikehardy mikehardy requested a review from Salakar June 16, 2019 19:53
@mikehardy
Copy link
Collaborator Author

I made a new v5.5.x release notes page and re-linked related things
In that v5.5.x I specified every breaking alteration so people could upgrade off one page of docs

I added a big "this is historical" alert on invites and made sure the DynamicLink doc had the correct info for the new domainURIPrefix style

...and that was basically it besides all the version numbers

Salakar
Salakar previously approved these changes Jun 18, 2019
View reviewed changes
@mikehardy
Copy link
Collaborator Author

Yeah, soooo about that. I have this habit of re-reading my PRs a bunch of times and I always find something. Actually forgot the new v5.5.x.md file, which is kind of critical. So needs a re-read and re-approve 🤦‍♂

Salakar
Salakar previously approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ye, wow I missed that too it's 5 am here, that's my excuse 🙄

@mikehardy
Copy link
Collaborator Author

There was a late-arriving typescript breaking change - super small, but still it's a break - which I wanted to get in v5.5.0 to batch breaks together, so I just merged it and updated the docs here. Sorry for the noise :-). I'll release a v5.5.0 like this now after one more review / local test run-through, the SDK upgrade is in CI now

@mikehardy mikehardy requested a review from Salakar June 18, 2019 13:15
@mikehardy mikehardy merged commit a02587b into invertase:v5.x.x Jun 19, 2019
@mikehardy mikehardy deleted the v5-sdk-update branch June 19, 2019 02:26
@mikehardy mikehardy restored the v5-sdk-update branch June 19, 2019 03:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Salakar Salakar Salakar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikehardy @Salakar