Skip to content

Commit 9bf9fa1

Browse files
authored
[BUGFIX] - patch releases to 5.5.3 (#2258)
* [BUGFIX][COMPILE][ANALYTICS] - conform to new config API location, Fixes #2259 * [BUGFIX][LINKS][domainURIPrefix] - correctly pass domainURIPrefix Fixes #2262
1 parent ac1f205 commit 9bf9fa1

File tree

7 files changed

+12
-13
lines changed

7 files changed

+12
-13
lines changed

RELEASE_PROCESS.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ This document is an attempt to write down all the steps in the release process f
1414

1515
## SDK Version numbers
1616

17-
1. Update the firebase registration version numbers to match the next version number
17+
1. Update and commit the firebase registration version numbers to match the next version number
1818
- iOS here: <https://github.com/invertase/react-native-firebase/blob/v5.x.x/ios/RNFirebase/RNFirebase.m#L20>
1919
- Android here: <https://github.com/invertase/react-native-firebase/blob/v5.x.x/android/src/main/java/io/invertase/firebase/ReactNativeFirebaseAppRegistrar.java#L36>
2020

android/src/main/java/io/invertase/firebase/ReactNativeFirebaseAppRegistrar.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public List<Component<?>> getComponents() {
3333
return Collections.singletonList(
3434
LibraryVersionComponent.create(
3535
"react-native-firebase",
36-
"5.5.0"
36+
"5.5.3"
3737
)
3838
);
3939
}

ios/RNFirebase/RNFirebase.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ - (id)init {
1717
if (self != nil) {
1818
DLog(@"Setting up RNFirebase instance");
1919
#ifdef REGISTER_LIB
20-
[FIRApp registerLibrary:@"react-native-firebase" withVersion:@"5.5.0"];
20+
[FIRApp registerLibrary:@"react-native-firebase" withVersion:@"5.5.3"];
2121
#endif
2222
}
2323
return self;

ios/RNFirebase/analytics/RNFirebaseAnalytics.m

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
#if __has_include(<FirebaseAnalytics/FIRAnalytics.h>)
55
#import <FirebaseAnalytics/FIRAnalytics.h>
6-
#import <FirebaseCore/FIRAnalyticsConfiguration.h>
76

87
@implementation RNFirebaseAnalytics
98
RCT_EXPORT_MODULE();
@@ -13,7 +12,7 @@ @implementation RNFirebaseAnalytics
1312
}
1413

1514
RCT_EXPORT_METHOD(setAnalyticsCollectionEnabled:(BOOL) enabled) {
16-
[[FIRAnalyticsConfiguration sharedInstance] setAnalyticsCollectionEnabled:enabled];
15+
[FIRAnalytics setAnalyticsCollectionEnabled:enabled];
1716
}
1817

1918
RCT_EXPORT_METHOD(setCurrentScreen:(NSString *) screenName screenClass:(NSString *) screenClassOverriew) {

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-firebase",
3-
"version": "5.5.0",
3+
"version": "5.5.3",
44
"author": "Invertase <[email protected]> (http://invertase.io)",
55
"description": "A well tested, feature rich Firebase implementation for React Native, supporting iOS & Android. Individual module support for Admob, Analytics, Auth, Crash Reporting, Cloud Firestore, Database, Dynamic Links, Functions, Messaging (FCM), Remote Config, Storage and more.",
66
"main": "dist/index.js",

src/modules/links/DynamicLink.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default class DynamicLink {
1616

1717
_android: AndroidParameters;
1818

19-
_dynamicLinkDomain: string;
19+
_domainURIPrefix: string;
2020

2121
_ios: IOSParameters;
2222

@@ -28,10 +28,10 @@ export default class DynamicLink {
2828

2929
_social: SocialParameters;
3030

31-
constructor(link: string, dynamicLinkDomain: string) {
31+
constructor(link: string, domainURIPrefix: string) {
3232
this._analytics = new AnalyticsParameters(this);
3333
this._android = new AndroidParameters(this);
34-
this._dynamicLinkDomain = dynamicLinkDomain;
34+
this._domainURIPrefix = domainURIPrefix;
3535
this._ios = new IOSParameters(this);
3636
this._itunes = new ITunesParameters(this);
3737
this._link = link;
@@ -66,16 +66,16 @@ export default class DynamicLink {
6666
build(): NativeDynamicLink {
6767
if (!this._link) {
6868
throw new Error('DynamicLink: Missing required `link` property');
69-
} else if (!this._dynamicLinkDomain) {
69+
} else if (!this._domainURIPrefix) {
7070
throw new Error(
71-
'DynamicLink: Missing required `dynamicLinkDomain` property'
71+
'DynamicLink: Missing required `domainURIPrefix` property'
7272
);
7373
}
7474

7575
return {
7676
analytics: this._analytics.build(),
7777
android: this._android.build(),
78-
dynamicLinkDomain: this._dynamicLinkDomain,
78+
domainURIPrefix: this._domainURIPrefix,
7979
ios: this._ios.build(),
8080
itunes: this._itunes.build(),
8181
link: this._link,

src/modules/links/types.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export type NativeSocialParameters = {|
4444
export type NativeDynamicLink = {|
4545
analytics: NativeAnalyticsParameters,
4646
android: NativeAndroidParameters,
47-
dynamicLinkDomain: string,
47+
domainURIPrefix: string,
4848
ios: NativeIOSParameters,
4949
itunes: NativeITunesParameters,
5050
link: string,

0 commit comments

Comments
 (0)