Skip to content

[BUGFIX] - patch releases to 5.5.3 #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2019
Merged

Conversation

mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Jun 19, 2019

The 5.5.0 release had a crashlytics compile bug that slipped through because of a combination of problems allowing that chunk of code to not even attempt compilation in CI

The 5.5.1 release includes a PR #2256 from @maxkomarychev that fixed the compile issue and (important for the future) fixed the podfile issue that allowed it to slip through and re-enabled v5 crashlytics for iOS in CI

The 5.5.0 and 5.5.1 release still had a compile error for Analytics #2259 - I'm still combing through release docs on the pods but analytics isn't in CI (:scream:) which is the same way the crashlytics error slipped through. I'll work on that later

And now 5.5.3 fixes issue #2262 with the new domainURIPrefix links parameter - I didn't plumb that breaking change correctly, this one isn't in my app yet so I couldn't see it via integration tests, and there's no v5 links e2e support so it slipped past me as I applied the change from #2051 during the SDK update

build errors are sort of "stop work" important so I released 5.5.1 and 5.5.2 and this is the versioning change that goes with it via v5 the release process we're currently using

When this is approved I need someone with git-power to create the v5.5.1,2,3 tags. Release notes will follow after v5.5.x is proven successfully integrated - I'm prioritizing support at the moment

Action items that are doable - check if I can get Analytics and Links at least in the compilation for e2e. Doing more doesn't make sense with v6 covering them fully but it'll put some more guardrails around the process


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy mikehardy requested review from Ehesp and Salakar June 19, 2019 07:56
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #2258 into v5.x.x will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           v5.x.x    #2258   +/-   ##
=======================================
  Coverage   76.27%   76.27%           
=======================================
  Files          61       61           
  Lines        1576     1576           
=======================================
  Hits         1202     1202           
  Misses        374      374

@mikehardy mikehardy changed the title Prepare for release 5.5.1 Prepare for release 5.5.2 Jun 19, 2019
@mikehardy
Copy link
Collaborator Author

Unfortunately something is wrong with CI right now - watchman is having permissions errors and this is usually file handles running out and CI needing a reboot or similar if I recall? 5.5.2 successfully integrates for me though I have 5.5.x with pods 6.current working successfully in my full app now

@mikehardy
Copy link
Collaborator Author

I've finished reviewing the iOS release notes and I think these 2 were the only breaking changes from pods 5.x.x to pods 6.current where the v5 codebase had not already moved away from deprecated things that were then removed

I have not attempted to handle any of the new deprecation added though, so v5 has technical debt now. That should be fine with v6 coming

Still the CI errors though - I can't fix that sorry

@mikehardy mikehardy added this to the v5.5.x milestone Jun 19, 2019
@mikehardy mikehardy changed the title Prepare for release 5.5.2 Prepare for release 5.5.3 Jun 19, 2019
@mikehardy mikehardy changed the title Prepare for release 5.5.3 [BUGFIX] - patch releases to 5.5.3 Jun 19, 2019
@mikehardy mikehardy merged commit 9bf9fa1 into invertase:v5.x.x Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants