Skip to content

v5 Update all Firebase SDK dependencies to current #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2019
Merged

v5 Update all Firebase SDK dependencies to current #2240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8912a0
Update all Firebase SDKs to current, alter API to match
mikehardy Jun 16, 2019
2ddefff
[INTERNAL][DEPENDENCIES] - updated all outdated packages incl react-n…
mikehardy Jun 17, 2019
3d0d4be
Merge branch 'v5.x.x' into v5-sdk-update
mikehardy Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ buildscript {
}
}
dependencies {
classpath 'com.android.tools.build:gradle:3.3.2'
classpath 'com.android.tools.build:gradle:3.4.1'
}
}

Expand Down Expand Up @@ -136,7 +136,6 @@ def supportVersion = rootProject.hasProperty('supportLibVersion') ? rootProject.
dependencies {
//noinspection GradleDynamicVersion
api "com.facebook.react:react-native:+"
// implementation "com.google.firebase:firebase-common:16.1.0"

/* ----------------------------
* REACT NATIVE FIREBASE
Expand All @@ -152,47 +151,39 @@ dependencies {
* ------------------------- */

// Ads
compileOnly('com.google.firebase:firebase-ads:15.0.1') {
// exclude `customtabs` as the support lib version is out of date
// we manually add it as a dependency below with a custom version
exclude group: 'com.android.support', module: 'customtabs'
}
compileOnly "com.google.firebase:firebase-ads:17.2.1"
// Authentication
compileOnly "com.google.firebase:firebase-auth:17.0.0"
// Analytics
compileOnly "com.google.firebase:firebase-analytics:16.5.0"
// Performance Monitoring
compileOnly "com.google.firebase:firebase-perf:16.2.4"
compileOnly "com.google.firebase:firebase-perf:17.0.2"
// Remote Config
compileOnly "com.google.firebase:firebase-config:17.0.0"
// Cloud Storage
compileOnly "com.google.firebase:firebase-storage:17.0.0"
// Invites
compileOnly "com.google.firebase:firebase-invites:17.0.0"
// Dynamic Links
// Dynamic Links (with invites sub-dependency for internal API)
compileOnly "com.google.firebase:firebase-dynamic-links:17.0.0"
compileOnly "com.google.firebase:firebase-invites:17.0.0"
// Real-time Database
compileOnly "com.google.firebase:firebase-database:17.0.0"
// Cloud Functions
compileOnly "com.google.firebase:firebase-functions:17.0.0"
// Cloud Firestore
compileOnly "com.google.firebase:firebase-firestore:19.0.0"
compileOnly "com.google.firebase:firebase-firestore:19.0.2"
// Cloud Messaging / FCM
compileOnly "com.google.firebase:firebase-messaging:18.0.0"
// Crashlytics
compileOnly('com.crashlytics.sdk.android:crashlytics:2.9.5@aar') {
compileOnly('com.crashlytics.sdk.android:crashlytics:2.10.1@aar') {
transitive = true
}
/* --------------------------------
* OPTIONAL SUPPORT LIBS
* -------------------------------- */

// For Firebase Ads
compileOnly "com.android.support:customtabs:$supportVersion"

// For React Native Firebase Notifications
api "com.android.support:support-v4:$supportVersion"

// For React Native Firebase Notifications
compileOnly 'me.leolin:ShortcutBadger:1.1.21@aar'
compileOnly 'me.leolin:ShortcutBadger:1.1.22@aar'
}
268 changes: 0 additions & 268 deletions android/src/main/java/io/invertase/firebase/invites/RNFirebaseInvites.java
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions android/src/main/java/io/invertase/firebase/invites/RNFirebaseInvitesPackage.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion android/src/main/java/io/invertase/firebase/links/RNFirebaseLinks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ private DynamicLink.Builder getDynamicLinkBuilder(final ReadableMap linkData) {
.createDynamicLink();
try {
builder.setLink(Uri.parse(linkData.getString("link")));
builder.setDynamicLinkDomain(linkData.getString("dynamicLinkDomain"));
builder.setDomainUriPrefix(linkData.getString("domainURIPrefix"));
setAnalyticsParameters(linkData.getMap("analytics"), builder);
setAndroidParameters(linkData.getMap("android"), builder);
setIosParameters(linkData.getMap("ios"), builder);
Expand Down
Loading