-
Notifications
You must be signed in to change notification settings - Fork 2.3k
docs(messaging): add warning for react-native-splash-screen
users
#3966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go farther. I strongly recommend react-native-bootsplash and people should not use splash-screen. They should actively migrate away, it's a dead repo with issues.
Co-authored-by: Mike Hardy <[email protected]>
@mikehardy Accepted your proposed changes 1 on 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks @jasperkuperus
Thanks for this. It'll require the |
Thanks. Indeed I didn't clone locally. |
react-native-splash-screen
usersreact-native-splash-screen
users
…nvertase#3966) Co-authored-by: Mike Hardy <[email protected]>
This comment saved me... thanks @jasperkuperus |
Description
Using React Native Firebase together with
react-native-splash-screen
might cause some issues. Especially formessaging().getInitialNotification()
andmessaging().onNotificationOpenedApp
. This PR adds a small comment to the documentation of these two methods to warn people about known issues.Related issues
Related issue where this was discussed: #3469 (comment)
Release Summary
N/A
Checklist
My change supports the following platforms;[]Android
[ ]iOS
My change includes tests;[ ]e2e
tests added or updated inpackages/\*\*/e2e
[ ]jest
tests added or updated inpackages/\*\*/__tests__
[ ] I have updated TypeScript types that are affected by my change.Test Plan
N/A -> Documentation only
🔥