Skip to content

docs(messaging): add warning for react-native-splash-screen users #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 15, 2020

Conversation

jasperkuperus
Copy link
Contributor

Description

Using React Native Firebase together with react-native-splash-screen might cause some issues. Especially for messaging().getInitialNotification() and messaging().onNotificationOpenedApp. This PR adds a small comment to the documentation of these two methods to warn people about known issues.

Related issues

Related issue where this was discussed: #3469 (comment)

Release Summary

N/A

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • [] Android
    • [ ] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

N/A -> Documentation only

🔥

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go farther. I strongly recommend react-native-bootsplash and people should not use splash-screen. They should actively migrate away, it's a dead repo with issues.

@jasperkuperus
Copy link
Contributor Author

@mikehardy Accepted your proposed changes 1 on 1.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @jasperkuperus

@mikehardy mikehardy requested a review from Ehesp July 21, 2020 17:58
@Ehesp
Copy link
Member

Ehesp commented Jul 22, 2020

Thanks for this. It'll require the gen:reference script to be re-run but one of us can sort this (assuming you didn't clone locally).

@jasperkuperus
Copy link
Contributor Author

Thanks for this. It'll require the gen:reference script to be re-run but one of us can sort this (assuming you didn't clone locally).

Thanks. Indeed I didn't clone locally.

@Salakar Salakar changed the title docs(messaging): Add warning for react-native-splash-screen users docs(messaging): add warning for react-native-splash-screen users Aug 15, 2020
@Salakar Salakar merged commit 67ca4d0 into invertase:master Aug 15, 2020
hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
@JDMathew
Copy link
Contributor

JDMathew commented May 4, 2022

This comment saved me... thanks @jasperkuperus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants