Skip to content

fix(app, sdks): firebase-ios-sdk 10.1.0 / firebase-android-sdk 31.0.2 #6641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

mikehardy
Copy link
Collaborator

Description

use new SDKs
...also a bump to the app-distribution gradle plugin, but we only see that in the test app

Related issues

Fixes #6638

Release Summary

One conventional commit

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Oct 28, 2022 at 0:56AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Oct 28, 2022 at 0:56AM (UTC)

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #6641 (ab4e352) into main (b2670ea) will decrease coverage by 18.69%.
The diff coverage is n/a.

❗ Current head ab4e352 differs from pull request most recent head 1e43e1a. Consider uploading reports for the commit 1e43e1a to get more accurate results

@@              Coverage Diff              @@
##               main    #6641       +/-   ##
=============================================
- Coverage     72.20%   53.51%   -18.68%     
- Complexity        0      690      +690     
=============================================
  Files           115      214       +99     
  Lines          4754    10700     +5946     
  Branches       1064     1681      +617     
=============================================
+ Hits           3432     5725     +2293     
- Misses         1240     4680     +3440     
- Partials         82      295      +213     

also a bump to the app-distribution gradle plugin, but we only see that
in the test app
@mikehardy mikehardy force-pushed the @mikehardy/dependency-updates branch from 819c239 to 1e43e1a Compare October 28, 2022 00:51
@mikehardy mikehardy merged commit 8367c98 into main Oct 28, 2022
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch October 28, 2022 02:15
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] Storage getDownloadURL() does not work with Firebase Emulator
1 participant