Skip to content

feat(ui): display canvas generation mode in status text #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

psychedelicious
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because: n/a

Have you updated all relevant documentation?

  • Yes
  • No n/a

Description

Add a generation mode indicator to canvas.

  • use the existing logic to determine if generation is txt2img, img2img, inpaint or outpaint
  • technically outpaint and inpaint are the same, just display "Inpaint" if its either
  • debounce this by 1s to prevent jank

I was going to disable controlnet conditionally when the mode is inpaint but that involves a lot of fiddly changes to the controlnet UI components. Instead, I'm hoping we can get inpaint moved over to latents by next release, at which point controlnet will work.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Screen.Recording.2023-07-23.at.10.38.26.pm.mov

Added/updated tests?

  • Yes
  • No : n/a

[optional] Are there any post deployment tasks we need to perform?

n/a

- use the existing logic to determine if generation is txt2img, img2img, inpaint or outpaint
- technically `outpaint` and `inpaint` are the same, just display
"Inpaint" if its either
- debounce this by 1s to prevent jank
@psychedelicious psychedelicious force-pushed the feat/canvas-generation-mode branch from 8c12602 to 28031ea Compare July 23, 2023 13:23
@blessedcoolant blessedcoolant merged commit 4f9c728 into main Jul 24, 2023
@blessedcoolant blessedcoolant deleted the feat/canvas-generation-mode branch July 24, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants