Download all model types. #3944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camenduru
requested review from
damian0815,
lstein,
blessedcoolant,
GreggHelt2,
StAlKeR7779 and
brandonrising
as code owners
lstein
requested changes
Jul 25, 2023
There was a problem hiding this comment.
Sadly, this does not work quite the way you expect. With your patch, the "STARTER MODELS" section ends up displaying the main, controlnet and lora models all mixed up together:
What you want to do is to modify the recommended_models() method in model_install_backend.py to return all recommended models rather than just the ones returned by starter_models(). I believe this will cause them to be downloaded in batch when --default_only --yes is set, but not mess up the UI when used interactively.
lstein
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.