Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: streamline workflows #7739

Merged
merged 11 commits into from
Mar 28, 2025
Merged

ci: streamline workflows #7739

merged 11 commits into from
Mar 28, 2025

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Remove CUDA and ROCm from test matrix. We don't have GPU runners so there's no point in running these.
  • Use uv for everything.

Related Issues / Discussions

n/a

QA Instructions

It it fits, I sits.

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added CI-CD Continuous integration / Continuous delivery Root python-deps PRs that change python dependencies python-tests PRs that change python tests labels Mar 5, 2025
@psychedelicious psychedelicious force-pushed the psyche/ci/streamline-workflows branch from 01babb0 to a33dda4 Compare March 5, 2025 23:09
@github-actions github-actions bot added the frontend PRs that change frontend files label Mar 5, 2025
@psychedelicious
Copy link
Collaborator Author

I've simulated failures of various types and everything is working as it should.

We'll need an override merge for this because it removes 4x workflows from the python test matrix.

@psychedelicious
Copy link
Collaborator Author

Oh, there is one weird thing. I couldn't make uv install a system python version and use it to install deps. It would install it, but then say it cannot install deps bc its a system python, even when the --system flag was provided. Dunno why.

So, it still uses the standard setup-python action.

This can be squash-merged, there was a bit of fumbling to get the pieces fitting together.

@psychedelicious
Copy link
Collaborator Author

Main benefit to this change is faster CI for python tests - uv resolves and installs deps much faster than pip.

@psychedelicious psychedelicious force-pushed the psyche/ci/streamline-workflows branch from 007d7df to c309131 Compare March 18, 2025 21:11
@psychedelicious psychedelicious force-pushed the psyche/ci/streamline-workflows branch 2 times, most recently from d01e2d8 to dedacf1 Compare March 28, 2025 21:40
@psychedelicious
Copy link
Collaborator Author

I've cleaned up the commits in this PR, bumped versions of ubuntu for linux-cpu, uv and ruff, and fixed some things the latest version of ruff didn't like.

@psychedelicious psychedelicious force-pushed the psyche/ci/streamline-workflows branch from 3ca8bb8 to ba26da4 Compare March 28, 2025 21:51
Need to bump both CI and pyproject.toml at the same time
Lots of squashed experimentation heh:

ci: manually specify python version in tests

ci: whoops typo in ruff cmds

ci: specify python versions for uv python install

ci: install python verbosely

ci: try forcing python preference?

ci: try forcing python preference a different way?

ci: try in a venv?

ci: it works, but try without venv

ci: oh maybe we need --preview?

ci: poking it with a stick

ci: it works, add summary to pytest output

ci: fix pytest output

experiment: simulate test failure

Revert "experiment: simulate test failure"

This reverts commit b99ca51.

ci: just use default pytest output

cI: attempt again to use uv to install python

cI: attempt again again to use uv to install python

Revert "cI: attempt again again to use uv to install python"

This reverts commit 3cba861.

Revert "cI: attempt again to use uv to install python"

This reverts commit b30f227.
ci: use uv in typegen-checks to generate types

experiment: simulate typegen-checks failure

Revert "experiment: simulate typegen-checks failure"

This reverts commit f53c687.
@psychedelicious psychedelicious force-pushed the psyche/ci/streamline-workflows branch from ba26da4 to ec0435b Compare March 28, 2025 21:52
@hipsterusername hipsterusername merged commit aaa6211 into main Mar 28, 2025
11 checks passed
@hipsterusername hipsterusername deleted the psyche/ci/streamline-workflows branch March 28, 2025 22:28
@psychedelicious psychedelicious mentioned this pull request Mar 28, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-CD Continuous integration / Continuous delivery frontend PRs that change frontend files python-deps PRs that change python dependencies python-tests PRs that change python tests Root
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants