Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: workflow library iteration 2 #7765

Merged
merged 19 commits into from
Mar 11, 2025
Merged

feat: workflow library iteration 2 #7765

merged 19 commits into from
Mar 11, 2025

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Split workflow library state into separate slice. The OG workflows slice is just for the actively loaded workflow.
  • Fix up RTKQ tag invalidation for workflow library.
  • Bump RTK to get fix for issue w/ infinite query.
  • Rework tag checkboxes to be AND filters. Update library service methods, HTTP API and frontend.

Related Issues / Discussions

n/a

QA Instructions

Try it out!

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@psychedelicious
refactor(ui): split workflow library state into separate slice
1a71346 
Has no business being in the workflow state slice.
@psychedelicious
chore(ui): remove unused WorkflowsRecent RTKQ tag
8730cd3 
This didn't actually do anything. Will be implementing the actual functionality that you'd _think_ this tag would do in a future change.
@psychedelicious
feat(ui): add cache tags for workflow library's infinite query
2d39777
@psychedelicious
fix(ui): updating workflow opened at invalidates infinite query cache
d3685af
@psychedelicious
fix(ui): updating workflow content should not invalidate the infinite…
786e4e2 
… query cache
@psychedelicious
docs(ui): add comments to workflow library cache invalidation
cadfa0c
@psychedelicious
chore(ui): bump @reduxjs/toolkit from 1.6.0 to 1.6.1
601fab6 
This brings in some fixes for the new infinite query support.
@psychedelicious
fix(ui): workflow library infinite query providesTags
00b05dc
@psychedelicious
feat(app): revised workflow library filtering by tag
b3ba105 
- Replace `get_counts` method with `get_tag_counts_with_filter` which gets the counts for a list of tags, filtering by a list of selected tags
- Update `get_many` logic to apply tag filtering with AND logic, to match the new `get_tag_counts_with_filter` method
- Update workflow library router
@psychedelicious
chore(ui): typegen
97da320
@psychedelicious
feat(ui): use new tag filtering for workflow library
e29b73a
@psychedelicious
feat(ui): "Reset Tags" -> "Reset Filters"
b3b1f1e
@psychedelicious
feat(ui): hide filters with no workflows
66cc52f
@psychedelicious
chore(ui): lint
b304e6e
@github-actions github-actions bot added api python PRs that change python files services PRs that change app services frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files labels Mar 11, 2025
@psychedelicious
Copy link
Collaborator Author

Reverted change to use AND logic for workflows across backend, HTTP API and UI. It's now OR logic. Kept the more efficient counts methods (e.g. one method/route to get counts for many tags at once, instead of a route that gets the count for only one tag at a time).

@psychedelicious psychedelicious merged commit deecb7f into main Mar 11, 2025
15 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/workflow-library-2 branch March 11, 2025 21:00
@psychedelicious psychedelicious mentioned this pull request Mar 12, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryhipp maryhipp maryhipp approved these changes

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@jazzhaiku jazzhaiku Awaiting requested review from jazzhaiku jazzhaiku is a code owner

Assignees
No one assigned
Labels
api frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies python PRs that change python files services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psychedelicious @maryhipp @hipsterusername