Change timm and controlnet-aux pins to fix LLaVA model support
#7846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th llava timm < 1.0.0 prevents llava models from working (broken in transformers). but controlnet-aux pinned it to an earlier version because otherwise it was breaking the ZoeDepth controlnet. we don't use ZoeDepth (replaced by depthAnything), and downgrading controlnet-aux seems to be acceptable. more context here: huggingface/controlnet_aux#106 huggingface/controlnet_aux#101
ebr
requested review from
lstein,
blessedcoolant and
hipsterusername
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes the version pin for controlnet-aux and updates the timm dependency to support LLaVA model compatibility.
- Removed an explicit version for controlnet-aux.
- Updated timm from an exact version (0.6.13) to a compatible range (~1.0.0).
Comments suppressed due to low confidence (1)
pyproject.toml:54
- The inline comment still references an override for timm imposed by controlnet-aux, which may now be outdated after removing the version pin from controlnet-aux. Consider updating or removing the comment to avoid confusion.
"timm~=1.0.0",
hipsterusername
approved these changes
Mar 26, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
timmbelow 1.0.0 prevents llava models from working (broken in transformers). butcontrolnet-auxpinstimmto an earlier version because otherwise it was breaking the ZoeDepth controlnet.we don't use ZoeDepth (replaced by depthAnything), and downgrading controlnet-aux seems to be acceptable.
more context here:
huggingface/controlnet_aux#106 huggingface/controlnet_aux#101
Note that this results in some warnings on startup, stemming from controlnet-aux:
we can probably silence the warnings as a separate enhancement
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)