Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodes): expanded masks not 100% transparent outside the fade out region #7854

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

psychedelicious
Copy link
Collaborator

Summary

The polynomial fit isn't perfect and we end up with alpha values of 1 instead of 0 when applying the mask. This in turn causes issues on canvas where outputs aren't 100% transparent and individual layer bbox calculations are incorrect.

Related Issues / Discussions

I actually noticed this in testing but convinced myself I was seeing things:

  • Inpaint a region
  • Accept the inpainted region as new raster layer
  • Toggle raster layer off and on - the area around the raster layer changes brightness subtly

The impact on bbox was noted here:k
https://discord.com/channels/1020123559063990373/1149506274971631688/1355010785042104503

QA Instructions

  • Inpaint a region
  • Accept the inpainted region as new raster layer
  • Toggle raster layer off and on - the area around the raster layer should not change at all
  • The new raster layer's blue box should be the right size - not the same size as bbox

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations labels Mar 28, 2025
@psychedelicious psychedelicious enabled auto-merge (rebase) March 30, 2025 22:19
…region

The polynomial fit isn't perfect and we end up with alpha values of 1 instead of 0 when applying the mask. This in turn causes issues on canvas where outputs aren't 100% transparent and individual layer bbox calculations are incorrect.
@psychedelicious psychedelicious force-pushed the psyche/fix/nodes/expand-mask-alpha branch from 1f99bac to 3dc5463 Compare March 30, 2025 22:19
@psychedelicious psychedelicious merged commit 4109ea5 into main Mar 31, 2025
11 checks passed
@psychedelicious psychedelicious deleted the psyche/fix/nodes/expand-mask-alpha branch March 31, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants