Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flux_redux.py with downsampling and weight options #7875

Merged
merged 7 commits into from
Apr 8, 2025

Conversation

skunkworxdark
Copy link
Contributor

@skunkworxdark skunkworxdark commented Apr 3, 2025

Add downsampling and weight to Redux node - This should allow the main prompt conditioning to gain some traction over a Redux conditioning.

Summary

The downsampling and weight idea is derived from https://github.com/kaibioinfo/ComfyUI_AdvancedRefluxControl

  • Downsampling of 3-4 is where the main prompt starts to gain some traction.
  • Weight of 0.3-0.4 is where it weakens the redux conditioning enough for the main prompt to have an effect.

Downsampling reduces the size of the redux conditioning
Weight reduces the intensity of the conditioning but not the size

Related Issues / Discussions

N/A

QA Instructions

Test defaults to work like the previous non-down-sampled redux

https://stable-diffusion-art.com/flux-redux/ - article on the original comfy node.

Merge Plan

Needs testing and reviewing and frontend consideration discussed

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations labels Apr 3, 2025
@skunkworxdark
Copy link
Contributor Author

@hipsterusername - here is the redux node changes. as discussed.

@github-actions github-actions bot added the frontend PRs that change frontend files label Apr 7, 2025
@psychedelicious
Copy link
Collaborator

  • Fixed a small issue in the node where an and should have been an or.
  • Added support to Canvas via new Image Influence setting for FLUX Redux. This mirrors the comfy node's UI. The mapping of influence settings to node parameters is done in invokeai/frontend/web/src/features/nodes/util/graph/generation/addFLUXRedux.ts. It's straightforward to edit that mapping to fine-tune image influence setting. For now, it matches the comfy node.

@psychedelicious psychedelicious self-requested a review April 8, 2025 00:29
@psychedelicious psychedelicious enabled auto-merge (rebase) April 8, 2025 00:29
@psychedelicious psychedelicious merged commit a0cf9e2 into invoke-ai:main Apr 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants